Review Board 1.6.3

scan can early exit for incrementColumnValue()

Review Request #1053 - updated 3 years, 6 months ago

khemani Reviewers
trunk hbase
HBASE-3082 jgray
None hbase
Ensure that during incrementColumnValue() the scan triggered by the get() does an early exit if it finds the KV in the memstore.
I have been testing it on my cluster. No unit testing yet.
Review request changed
Updated 3 years, 6 months ago (October 20th, 2010, 9:31 p.m.)
I think I have taken care of all the review feedback
Posted 3 years, 6 months ago (October 20th, 2010, 9:41 p.m.)

   

  
Why not put these into the base class?  Why create an entirely new class just to hold these?
  1. It is not added to the base class so as not to alter the public Scan API.
Would this code be cleaner if we didnt have to use instanceof?
  1. yes, i agree it will be cleaner w/o instanceof. But in that case we will have to pass the flags all the way from HRegion to StoreScanner. A number of signatures will have to change.
    
    Another approach could be to only instantiate InternalScan in the server side. But again that is quite a bit of code change.
    
    Having an internal-scan should be useful. After all, a scan touches a lot of data and certain other tasks can potentially be piggybacked on a scan.
  2. ok that makes sense. let's go with it then.
Ship it!
Posted 3 years, 6 months ago (October 22nd, 2010, 4:09 p.m.)