HUE-6808 [frontend] Remove _blank targets

Review Request #11039 - Created July 6, 2017 and submitted

Enrico Berti
hue
master
hue
jennykim, johan, krish, ranade, romain, weixia
commit f48069b8de82622078496e2271c6be9ec95ab112
Author: Enrico Berti <hello@enricoberti.com>
Date:   Thu Jul 6 16:24:09 2017 +0200

    HUE-6808 [frontend] Remove _blank targets

:100644 100644 7ccec0ce1c... 5f84b6a1af... M	apps/about/src/about/templates/admin_wizard.mako
:100644 100644 e7fab2b3e4... ef48f52f45... M	apps/jobbrowser/src/jobbrowser/models.py
:100644 100644 599cf40ff3... bdeb179645... M	apps/jobbrowser/src/jobbrowser/tests.py
:100644 100644 51b36057b5... 6e940c3168... M	apps/metastore/src/metastore/templates/metastore.mako
:100644 100644 f49e9a2d37... f3ca78a4a3... M	apps/oozie/src/oozie/templates/editor2/bundle_editor.mako
:100644 100644 34e20f6857... 5ac2a3f58b... M	apps/oozie/src/oozie/templates/editor2/common_scheduler.inc.mako
:100644 100644 59d370cbbe... d7eb712391... M	apps/oozie/src/oozie/templates/editor2/common_workflow.mako
:100644 100644 1021374687... 62cad4714a... M	apps/oozie/src/oozie/templates/editor2/submit_job_popup.mako
:100644 100644 f5c6df2aec... 088da81dbb... M	apps/oozie/src/oozie/templates/editor2/workflow_editor.mako
:100644 100644 b923283377... 9bd983cd2f... M	apps/security/src/security/templates/hdfs.mako
:100644 100644 066dce7bd2... 50e019bdba... M	apps/security/src/security/templates/hive.mako
:100644 100644 4f00ca19a7... 7bf9bc079a... M	apps/security/src/security/templates/sentry.mako
:100644 100644 d56a168b81... c00db9ca08... M	desktop/core/src/desktop/templates/document_browser.mako
:100644 100644 23cf7939f4... f6235d25e6... M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 60439a7709... b848840ba4... M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 8f8e067566... aa60499d01... M	desktop/libs/indexer/src/indexer/templates/indexer.mako
:100644 100644 68cd45b2a0... 96ee19ddc6... M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
Manual on Chrome
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
  1. Ship It!
  2. For the ones where we use the external-link icon it makes more sense to have target="_blank" no?
    1. i think we can drop that icon and use something else, opening in blank is quite shitty anyways (if not for links externally to the Hue app, like oozie help)

  3. 
      
Review request changed

Status: Closed (submitted)

  1. One issue with this one is that it is not really complete until we need to add the sample popup to all the links.

    e.g. in create table wizard we can select a file and have the link, but now if we click we lose the current page even if coming back via the history.

    However, if we add the file sample popup, document sample popup etc it would be perfect!

  2. 
      
Loading...