HUE-5304 [indexer] Open correctly the links from Assist in the new indexer

Review Request #11113 - Created July 17, 2017 and submitted

Enrico Berti
hue
master
hue
jennykim, johan, krish, ranade, romain, weixia
commit d0baf399da61c40c882968752a04c1795a862ee7
Author: Enrico Berti <hello@enricoberti.com>
Date:   Mon Jul 17 17:01:56 2017 +0200

    HUE-5304 [indexer] Open correctly the links from Assist in the new indexer

:100644 100644 de76cb0e04... 626e4ae2d1... M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 bf348e04c5... 3e7a837cc5... M	desktop/libs/indexer/src/indexer/templates/indexes.mako
Manual on Chrome
  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
  1. 
      
  2. Move above #27?

    (alphabetical)

  3. desktop/core/src/desktop/templates/assist.mako (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    Pretty hacky, couldn't we simplify with something like?

    self.loadApp('editor');
    self.getActiveAppViewModel(function (viewModel) {
    viewModel.openNotebook(uuid);
    })

    (and hueUtils.waitForVariable if needed). We should just need to load the indexes app, then load the index?

    1. i'm not sure it would be simpler (pseudo code):

      var currentAppSub = huePubSub.subscribe('set.current.app.view.model', function (viewModel) {
        viewModel.loadIndex(xxxx)
      });
      self.disposals.push(currentAppSub.remove.bind(currentAppSub));
      huePubSub.publish('get.current.app.view.model');
      

      and we need to keep publishing get.current.app.view.model until the model itself is the correct one...

  4. 
      
Review request changed

Status: Closed (submitted)

Loading...