Refactor "Corrupt Data" Tests in TestHLogSplit


Submitter:	Alex Newman	Reviewers
Branch:		Groups:	hbase
Bugs:	hbase-2935	People:	nspiegelberg
Change Number:	None	Repository:	hbase

Description:

So I took the approach taken with the instrumented sequence file rider. Not sure if exposing those methods in the WALReader is cool so I am down with other suggestions.

- Add a FaultySequenceFileLogReader
- Un-commented the 2935 tests

Testing Done:

Running on our internal hudson as I type this. Also I ran the TestHLogSplit test locally. I'll update the review if hudson is green.

Expand All

This looks great to me.  Only one thing that seems odd, the first thing below.   Nicolas, what you think?

src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java (Diff revision 1)

Do you need to do this?  You can't get your WALReader in before first construction?

I think I see why you want to use it... its because the test already has an HLog?  What about just making a new HLog instance in your tests so you don't have to have this?

Nicolas 3 years, 4 months ago (October 31st, 2010, 9:14 p.m.)

I think it would be easier to change logReaderClass to package private and directly access that.  Especially since the wal namespace is so restrictive

src/test/java/org/apache/hadoop/hbase/regionserver/wal/FaultySequenceFileLogReader.java (Diff revision 1)

enum.valueOf might help here?  see http://leepoint.net/notes-java/oop/enums/enums.html

Reviewers (People)
- added nspiegelberg

src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java (Diff revision 1)

i had a quick look and i dont think there is a way out, since logWriterClass (and reader) are statics, there is no way to be first to the punch, since i believe surefire is running all the tests in 1 VM.

Probably making this a package private instead woudl be a good goal.  It'd be nice if there was a annotation to indicate this was  test hook, but doc should suffice for now. so 'static void resetLogReaderClass'

Diff
- added Diff r2

Description:

sta^ck and ryan's suggestions

src/test/java/org/apache/hadoop/hbase/regionserver/wal/FaultySequenceFileLogReader.java (Diff revisions 1 - 2)

woops pretend this says 
    return FailureType.valueOf(conf.get("faultysequencefilelogreader.failuretype", FailureType.NONE.name()));

I'm okay with the general concept/direction.  I think you should get rid of resetLogReaderClass(), but other than that, it looks pretty clean :)  I think there's more edge cases with IOE/ParseExceptions that we could theoretically handle, but this is a positive step and mitigates the regression.

Alex Newman 3 years, 4 months ago (November 1st, 2010, 10:04 a.m.)

Right on, what are some edge cases? What's the best way to nuke that state? Eventually, with distributed log splitting, this will eventually need to work in a distributed way.

Anything else need to be done here?

You have a pending review.

Other reviews

Your comment

Review Board 1.6.3

This change has been marked as submitted.