Review Board 2.0.8


Refactor "Corrupt Data" Tests in TestHLogSplit

Review Request #1115 - Created Oct. 28, 2010 and submitted

Information
Alex Newman
old-hbase
hbase-2935
Reviewers
hbase
nspiegelberg
So I took the approach taken with the instrumented sequence file rider. Not sure if exposing those methods in the WALReader is cool so I am down with other suggestions.

\- Add a FaultySequenceFileLogReader
\- Un-commented the 2935 tests
Running on our internal hudson as I type this. Also I ran the TestHLogSplit test locally. I'll update the review if hudson is green.
Posted (Oct. 29, 2010, 8:44 a.m.)



  
woops pretend this says 
    return FailureType.valueOf(conf.get("faultysequencefilelogreader.failuretype", FailureType.NONE.name()));
Ship it!
Posted (Oct. 31, 2010, 2:18 p.m.)
I'm okay with the general concept/direction.  I think you should get rid of resetLogReaderClass(), but other than that, it looks pretty clean :)  I think there's more edge cases with IOE/ParseExceptions that we could theoretically handle, but this is a positive step and mitigates the regression.
  1. Right on, what are some edge cases? What's the best way to nuke that state? Eventually, with distributed log splitting, this will eventually need to work in a distributed way.
Posted (Nov. 4, 2010, 8:25 a.m.)
Anything else need to be done here?