HUE-7010 [sqoop] Take configured databases from librdms instead of hardcoding the list of drivers

Review Request #11244 - Created Aug. 1, 2017 and updated

Prachi Poddar
hue
HUE-7010
1afb214...
romain
commit 3fa90048ae30e77a0f44a875adf78736e570be21
Author: Prachi Poddar <prachi.poddar@cloudera.com>
Date:   Tue Aug 1 15:17:15 2017 -0700

    HUE-7010 [sqoop] Take configured databases from librdms instead of hardcoding the list of drivers

:100644 100644 d427d6eb19... 1140062f1c... M	desktop/libs/indexer/src/indexer/indexers/rdbms.py
:100644 100644 d698b6b150... 5e92b12aca... M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 ca8e4a1f7c... 5df76625cd... M	desktop/libs/indexer/src/indexer/urls.py

Manual on Chrome

  • 13
  • 0
  • 0
  • 0
  • 13
Description From Last Updated
Remove? Romain Rigaux
Could we use get_server_choices() to get the initial list and iterate on it? Romain Rigaux
Based on event change? self.rdbmsMode.subscribe(function(newValue) { if (newValue == 'configRdbms' && self.rdbmsTypes().length == 0) { ... } }) Romain Rigaux
Could remove the '[]' Romain Rigaux
Did you see the previous comment on using self.rdbmsMode.subscribe? Romain Rigaux
from librdbms.conf import get_server_choices Romain Rigaux
No really needed Romain Rigaux
self.rdbmsMode.subscribe(function(newVal) { .... ? Romain Rigaux
Usually we style like this to have more readable multi lines: ...([ {'value': 'mysql', 'name': 'MySQL'}, {'value': 'oracle', 'name': 'Oracle'}, ... Romain Rigaux
if ( space Romain Rigaux
} else if ( spaces Romain Rigaux
I don't think we have a db2 python librdms connector? Romain Rigaux
JDBC on top? Romain Rigaux
  1. 
      
  2. Could we use get_server_choices() to get the initial list and iterate on it?

  3. Based on event change?

    self.rdbmsMode.subscribe(function(newValue) {
    if (newValue == 'configRdbms' && self.rdbmsTypes().length == 0) {
    ...
    }
    })

    1. Adding self.rdbmsTypes().length == 0 doesn't make sense as the driver list should change when we toggle between the two modes as there might be different lists corresponding to both the modes.

  4. Could remove the '[]'

  5. 
      
  1. 
      
  2. Did you see the previous comment on using

    self.rdbmsMode.subscribe?

  3. 
      
  1. 
      
  2. from librdbms.conf import get_server_choices

  3. No really needed

  4. self.rdbmsMode.subscribe(function(newVal) {
    ....

    ?

  5. Usually we style like this to have more readable multi lines:

    ...([
    {'value': 'mysql', 'name': 'MySQL'},
    {'value': 'oracle', 'name': 'Oracle'},
    {'value': 'postgresql', 'name': 'PostgreSQL'},
    {'value': 'db2', 'name': 'DB2'},
    {'value': 'jdbc', 'name': 'JDBC'}
    ])

  6. 
      
Review request changed

Commit:

-034ab3ee38da523486164c202a991e414a82ed12
+1afb214f64696381c8d5b30ff657895e21db5f90

Diff:

Revision 4 (+30 -13)

Show changes

  1. 
      
  2. I don't think we have a db2 python librdms connector?

  3. 
      
Loading...