HUE-7019 [fb] show_download_button is not integrated in the backend

Review Request #11265 - Created Aug. 4, 2017 and submitted

Ying Chen
hue
master
HUE-7019
hue
enricoberti, johan, krish, romain, weixia
commit 0f078195475605f2763d00f2378b61dbf21ac5cc
Author: Ying Chen <yingchen@cloudera.com>
Date:   Thu Aug 3 19:43:17 2017 -0700

    HUE-7019 [fb] show_download_button is not integrated in the backend

:100644 100644 145d71dfcb... 6e78468d17... M    apps/filebrowser/src/filebrowser/views.py


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. 
      
  2. desktop/libs/notebook/src/notebook/views.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    We should remove those, as the current setting is only about the File Browser.

    In another jira, we could create an ENABLE_DOWNLOAD property in 'desktop' conf and use it for the editor and search dashboards.

    SHOW_DOWNLOAD_BUTTON property could even have a dynamic_default (e.g. https://github.com/cloudera/hue/blob/master/desktop/libs/notebook/src/notebook/conf.py#L148) on desktop.conf.ENABLE_DOWNLOAD

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...