HUE-7055 [importer] Option to add column other than primary key to split-by

Review Request #11282 - Created Aug. 7, 2017 and submitted

Prachi Poddar
hue
HUE-7055
126ae24...
romain
commit dee5c7bd510dbff66199e34c8b6521ddbb1a6542
Author: Prachi Poddar <prachi.poddar@cloudera.com>
Date:   Mon Aug 7 10:11:45 2017 -0700

    HUE-7055 [importer] Option to add column other than primary key to split-by

:100644 100644 05bd0603fe... d555be1692... M	desktop/libs/indexer/src/indexer/indexers/rdbms.py
:100644 100644 3be05746c0... 1662b2d363... M	desktop/libs/indexer/src/indexer/templates/importer.mako

Yes, for all the scenarios. working fine!

  • 3
  • 0
  • 1
  • 0
  • 4
Description From Last Updated
Could we avoid the duplication? Romain Rigaux
Expected to be removed? Romain Rigaux
Move those to extra destination Sqoop properties? Romain Rigaux
  1. 
      
  2. desktop/libs/indexer/src/indexer/indexers/rdbms.py (Diff revision 1)
     
     
     
     
     
     

    Could we avoid the duplication?

    1. Can't think of a way to avoid it. We only need the --split-by attribute when the user selects a specific column from the dropdown. Otherwise, primary key is by default used by sqoop.

    2. Could you add a _helper method? The idea is to avoid any duplication.
  3. ko.observableArray('') --> ko.observableArray()

    ?

  4. 
      
  1. 
      
  2. Expected to be removed?

  3. desktop/libs/indexer/src/indexer/templates/importer.mako (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     

    Move those to extra destination Sqoop properties?

  4. 
      
Review request changed

Status: Closed (submitted)

Loading...