HUE-7004 [notebook] Fix special character typos

Review Request #11300 - Created Aug. 8, 2017 and submitted

Information
Sai Chirravuri
hue
master
HUE-7004
f80a997...
Reviewers
hue
romain

commit afe5da96daa31be0137f91cc4e151029e3616a4d
Author: krish krish@cloudera.com
Date: Tue Aug 8 15:19:39 2017 -0700

HUE-7004 [notebook] Fix special character typos

Special charaters were causing mako.e.CompileException: Unicode decode
operation of encoding 'ascii' failed at line: 0 char: 0
make[3]: *** [compile-locale] Error 1 in post commit jobs.

:100644 100644 3a86c6e... 1c3b0c1... M desktop/core/src/desktop/templates/config_ko_components.mako

Eventhough nothing shows up ehre. Diff looks like this

krish@Mac ~/dev/hue> git diff HEAD~1
diff --git a/desktop/core/src/desktop/templates/config_ko_components.mako b/desktop/core/src/desktop/templates/config_ko_components.mako
index 3a86c6e..087c5a1 100644
--- a/desktop/core/src/desktop/templates/config_ko_components.mako
+++ b/desktop/core/src/desktop/templates/config_ko_components.mako
@@ -431,14 +431,14 @@ from desktop.views import _ko
var self = this;

     self.values = ko.observableArray(params.values().filter(function (value) {

-??????????return value.key && value.key() && value.value && value.value();
-????????}));
-
-????????self.values.subscribe(function (newValues) {
-??????????params.values(self.values().filter(function (value) {
-????????????return value.key && value.key() && value.value && value.value();
-??????????}))
-????????});
+ return value.key && value.key() && value.value && value.value();
+ }));
+
+ self.values.subscribe(function (newValues) {
+ params.values(self.values().filter(function (value) {
+ return value.key && value.key() && value.value && value.value();
+ }))
+ });

     self.options = typeof params.property.options !== 'undefined' ? $.map(params.property.options(), function (option) {
       return { value: option }
Enrico Berti
Sai Chirravuri
Enrico Berti
Sai Chirravuri
Review request changed

Status: Closed (submitted)

Loading...