HUE-7091 [autocomplete] Show whether a column is a partition key or not in the autocomplete suggestions

Review Request #11310 - Created Aug. 10, 2017 and submitted

Johan Åhlén
hue
master
hue
enricoberti, jgauthier, krish, ranade, romain, weixia, yingc
commit d67198bb5fac20c121a664cd070197ee90acfd3f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Aug 10 14:42:07 2017 +0200

    HUE-7091 [autocomplete] Show whether a column is a partition key or not in the autocomplete suggestions

:100644 100644 a25301f8a3... 01d2057bf4... M	desktop/core/src/desktop/static/desktop/js/sqlAutocompleter3.js
:100644 100644 43f0e53ed0... 4642cb933b... M	desktop/core/src/desktop/templates/hue_ace_autocompleter.mako

Manual on Chrome

This is also needed in order to suggest filters for the missing partition key in filter risk

https://dl.dropbox.com/s/dvwuksgpvlq67ll/Screenshot%202017-08-10%2014.41.03.png?dl=0

  1. Ship It!
  2. 
      
  1. Nice!

    It is also probably worth adding the key icon to the list of columns (like Kudu PKs)! It will help for the missing key risk alert too (and fine to have same icon for pk, part keys).

    (BTW: with the join data, maybe we introduce FK keys at some point)

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...