HUE-7108 [desktop] Add config check to see if the migration history table is up to date

Review Request #11320 - Created Aug. 10, 2017 and submitted

Sai Chirravuri
hue
master
HUE-7108
e419923...
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc

commit 17a87c2d0f84f41e883c3d8f6d9a38b8b8d6b21f
Author: krish krish@cloudera.com
Date: Thu Aug 10 18:30:23 2017 -0700

HUE-7108 [desktop] Add config check to see if the migration history table is up to date

:100644 100644 2c42793... cd540ed... M desktop/core/src/desktop/appmanager.py
:100644 100644 178a9d2... 9aed92d... M desktop/core/src/desktop/conf.py

manual

  • 4
  • 0
  • 3
  • 0
  • 7
Description From Last Updated
BTW: How do we know that this works with all the DBs? SELECT if probably fine but wondering (check with ... Romain Rigaux
migration_history_entries = [] above or we might get undefined variable later if exception? Romain Rigaux
Could we get the names of the tables/migrations? That would help a lot for debugging. Romain Rigaux
Indentation to 2? Romain Rigaux
  1. 
      
  2. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Move above #31?

  3. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    BTW: How do we know that this works with all the DBs? SELECT if probably fine but wondering
    (check with Weixia if our tests run on multiple dbs?)

    1. https://docs.djangoproject.com/en/1.11/topics/db/sql/#executing-custom-sql-directly
      Weixia says check_config() runs on oracle, postgres and mysql everyday.

  4. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    migration_history_entries = [] above or we might get undefined variable later if exception?

  5. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    LOG.exception and no %s
    ?

  6. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Beware, file overrides file function

  7. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Could we get the names of the tables/migrations?

    That would help a lot for debugging.

    1. you mean the ones that are missing and add it to the config message ?

  8. 
      
  1. 
      
  2. desktop/core/src/desktop/conf.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Indentation to 2?

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...