HUE-7107 [core] HUE4 group access doesn't reflect on Interface

Review Request #11337 - Created Aug. 11, 2017 and submitted

Ying Chen
hue
master
HUE-7107
romain
commit a53ef56748a35de262992707b1dd8664d6b2afe8
Author: Ying Chen <yingchen@cloudera.com>
Date:   Mon Aug 14 12:32:28 2017 -0700

    HUE-7107 [core] HUE4 group access doesn't reflect on Interface

:100644 100644 d21b3f3801... 48e51a48ed... M    desktop/core/src/desktop/tests.py
:100644 100644 d89d4a6314... a3aa1cc403... M    desktop/libs/notebook/src/notebook/conf.py
:100644 100644 74052ce9f1... 628466b88d... M    desktop/libs/notebook/src/notebook/decorators.py
:100644 100644 1b71158f71... eb618dcf59... M    desktop/libs/notebook/src/notebook/views.py


  • 0
  • 0
  • 15
  • 0
  • 15
Description From Last Updated
  1. 
      
  2. request.GET.get('type', 'hive')

  3. desktop/libs/notebook/src/notebook/decorators.py (Diff revision 2)
     
     
     
     
     
     
     
     

    We should somehow unify if with notebook/conf.py
    (as we duplicate the logic in both places)

  4. indexer --> search

    We should also include if 'ANALYTICS' if on for the Solr engine (when it is Solr 6), as Solr SQL only exists there. We should also validate that we support it too at some point. I can explain in person

    1. also need help with this one
  5. Those are actually not necesserally the same names, I can explain in person the difference between 'notebook' (what matters here) and 'librdbms'

  6. 
      
  1. Add tests (similar to the UI one of my past 2 commits) about that in notebook/tests.py?

  2. ..(user, interpreter)

    ?

  3. 'indexer' --> 'search'
    ?

    And later we should add another property (can explain in person)

  4. Move one line below?

  5. 
      
  1. 
      
  2. desktop/core/src/desktop/tests.py (Diff revision 4)
     
     
     

    Should be 401 still?

  3. desktop/core/src/desktop/tests.py (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Put this one in a if? (in case the test cluster does not have Solr)

    if 'search' not in desktop.conf.APP_BLACKLIST.get():
    ...

  4. desktop/core/src/desktop/tests.py (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Same, and might be simpler to remove all spark references from above and just put the selected code in the if:

    if 'spark' not in desktop.conf.APP_BLACKLIST.get():
    ...

  5. Could you remove ''text', 'markdown'' from the list?

    (We might want to still allow to keep those even if there is no spark)

  6. 
      
  1. Last nits!

  2. desktop/core/src/desktop/tests.py (Diff revision 5)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    if 'spark' not in desktop.conf.APP_BLACKLIST.get():

    for the whole group?

    If there is no spark enabled in the cluster for Hue, line 653 should fail

    1. Is there a way to pre-check if an app is enabled? Is it possible this happen to other apps like oozie or impala also?
      Thanks.
  3. desktop/libs/notebook/src/notebook/tests.py (Diff revision 5)
     
     
     
     
     
     
     

    Should not be needed? (grants only needed for SQL queries I think)

  4. 
      
  1. 
      
  2. desktop/core/src/desktop/tests.py (Diff revision 6)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    In block:
    if 'search' not in desktop.conf.APP_BLACKLIST.get()

  3. desktop/core/src/desktop/tests.py (Diff revision 6)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    In block:

    if 'spark' not in desktop.conf.APP_BLACKLIST.get()

  4. 
      
  1. 
      
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...