[importer] Multiple changes in sqoop importer

Review Request #11408 - Created Aug. 22, 2017 and updated

Prachi Poddar
hue
romain
commit c4c08a5bc52c72648d458468f176e8a277a235cb
Author: Romain Rigaux <romain@cloudera.com>
Date:   Mon Aug 7 17:54:52 2017 -0700

    [importer] Multiple changes in sqoop importer

:100644 100644 7f85cf9985... a78887e376... M	apps/oozie/src/oozie/models2.py
:100644 100644 6c3ac2bb1c... aa0b8cb4b1... M	desktop/core/src/desktop/static/desktop/js/assist/assistDbSource.js
:100644 100644 51062590df... a32a8d54e7... M	desktop/libs/indexer/src/indexer/api3.py
:100644 100644 454207a332... c62dc79b3d... M	desktop/libs/indexer/src/indexer/fields.py
:100644 100644 81e514f289... 333b07f021... M	desktop/libs/indexer/src/indexer/indexers/rdbms.py
:100644 100644 77fbade5ce... c830dbad20... M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 e08129aa66... 21c6fe89ca... M	desktop/libs/librdbms/src/librdbms/server/oracle_lib.py
:100644 100644 ec9a29b919... b35daf030b... M	desktop/libs/librdbms/src/librdbms/server/postgresql_lib.py
:100644 100644 a774b86504... 816d01b413... M	desktop/libs/notebook/src/notebook/connectors/base.py
:100644 100644 9555a3f755... ef28ee7fa5... M	desktop/libs/notebook/src/notebook/connectors/jdbc.py

Yes

  • 13
  • 0
  • 0
  • 0
  • 13
Description From Last Updated
Could we simplify and have only one regexp? e.g. maybe --query((?!--).+?) --query(.+?)(--)?$ Romain Rigaux
Could we do this only when there is a --query found? (basically one main 'if') and keep the previous behavior ... Romain Rigaux
Could we avoid a new field and sort it here if we need? Romain Rigaux
Which cases is that? The thin? Romain Rigaux
spaces afters , Romain Rigaux
ditto Romain Rigaux
Could you do a list comprehension with a join([ .... if element['keep']) ? Romain Rigaux
Duplicated code with above? Romain Rigaux
Duplication with above? Romain Rigaux
Duplication with above? Romain Rigaux
mysql.vpc.cloudera.com --> mysql.vpc.gethue.com Romain Rigaux
ditto Romain Rigaux
hdfs://localhost:8020/user/hue/file.hue --> /user/hue/data Romain Rigaux
  1. Could you also push it to a sqoop2 branch?

  2. apps/oozie/src/oozie/models2.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    Could we simplify and have only one regexp?

    e.g. maybe

    --query((?!--).+?)

    --query(.+?)(--)?$

  3. apps/oozie/src/oozie/models2.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Could we do this only when there is a --query found? (basically one main 'if') and keep the previous behavior otherwise?

  4. desktop/libs/indexer/src/indexer/api3.py (Diff revision 1)
     
     
     
     

    Could we avoid a new field and sort it here if we need?

  5. Which cases is that?

    The thin?

  6. spaces afters ,

  7. desktop/libs/indexer/src/indexer/indexers/rdbms.py (Diff revision 1)
     
     
     
     
     

    Could you do a list comprehension with a join([ .... if element['keep']) ?

  8. desktop/libs/indexer/src/indexer/indexers/rdbms.py (Diff revision 1)
     
     
     
     
     
     

    Duplicated code with above?

  9. desktop/libs/indexer/src/indexer/indexers/rdbms.py (Diff revision 1)
     
     
     
     
     

    Duplication with above?

  10. desktop/libs/indexer/src/indexer/indexers/rdbms.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Duplication with above?

  11. mysql.vpc.cloudera.com --> mysql.vpc.gethue.com

  12. hdfs://localhost:8020/user/hue/file.hue --> /user/hue/data
  13. 
      
Loading...