HUE-7088 [core] Display a warning when users is accessing a Hue 3

Review Request #11472 - Created Sept. 6, 2017 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-7088
hue
enricoberti, jgauthier, johan, krish, ranade, romain, weixia, yingc
commit 6915106cb7802edbebc0c4f1533bdb96a458307d
Author: jdesjean <jgauthier@cloudera.com>
Date:   Wed Sep 6 13:05:47 2017 -0700

    HUE-7088 [core] Display a warning when users is accessing a Hue 3

:100644 100644 43858f5cf8... 9b89bd4522... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 80da38c213... 3e8cc85b2d... M	desktop/core/src/desktop/static/desktop/less/hue.less
:100644 100644 5f36d35e8b... 2bd6960a54... M	desktop/core/src/desktop/templates/common_header.mako
:100644 100644 e428c48320... 8a296cb3a1... M	desktop/core/src/desktop/views.py


  • 2
  • 0
  • 11
  • 1
  • 14
Description From Last Updated
Remove this one and either have a 'message = None'? (to avoid using a list) Romain Rigaux
Inline it instead? Romain Rigaux
  1. 
      
  2. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    aMessage --> messages

    ?

  3. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    In Python the convention is lower case with underscores, e.g.

    isRequestHueOld --> is_request_hue_old

  4. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    '<a href="%s" style="color: #FFF; font-weight: bold">%s</a>' % (url, url)

    No need ot first () and space after commas

  5. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    If we want to simplify, it is also fine to have the load balancer message in prioriy, then the old Hue 3 message? (and no need to css change this way)

    Having many messages make Hue UI look pretty awkward.

  6. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    if messages:

    False if list is empty

  7. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    no need of ()

    class="...

    no spaces around = for css

  8. desktop/core/src/desktop/views.py (Diff revision 2)
     
     
     
     
     

    As we use those only one time, probably better to not create two functions?

    (especially that they look like real Django views)

  9. desktop/core/src/desktop/views.py (Diff revision 2)
     
     

    Here I would recommend to just point to '/hue/'

    In practice, not all the URL can be rebuilt like that (e.g. Oozie Dashboard, Job Browser etc).

  10. 
      
  1. 
      
  2. desktop/core/src/desktop/static/desktop/less/hue.less (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Seems quite specific to the hue 3 warning banner, how about .hue-3-banner-... or .version-banner-...

  3. Try to restrict to @cui-... colors, see colors.less

  4. desktop/core/src/desktop/templates/common_header.mako (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    put above in hue-cross-version.less and drop this.

  5. 
      
  1. Ship It!
  2. Not sure how this would behave if a user has a banner with custom height defined. Is it needed?

    1. I agree that it won't work. Unfortunately, that's how the banner is designed at the moment in Hue 3 and we'd have to refactor it to fix it. This change is only to fix the low hanging bug that's currently there.

  3. 
      
  1. Just 2 simplifications?

  2. desktop/core/src/desktop/views.py (Diff revision 5)
     
     

    Remove this one and either have a 'message = None'? (to avoid using a list)

  3. desktop/core/src/desktop/views.py (Diff revision 5)
     
     
     

    Inline it instead?

    1. Can I get some background on why inlining this method is preferred? My current assumption is that this method improves readability.

    2. cf. above, this function is a one liner and has the same signature as a regular Django view, usually compact and simple is easier to read in Python

  4. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...