HUE-7362 [frontend] Improve the autocomplete logic of the inline autocompleter

Review Request #11712 - Created Oct. 5, 2017 and submitted

Information
Johan Åhlén
hue
master
Reviewers
hue
enricoberti, jgauthier, ranade, romain, weixia, yingc
commit 59cc661ac152780fe742c23407ff14e2b2164f52
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 5 13:11:48 2017 +0200

    HUE-7362 [frontend] Improve the autocomplete logic of the inline autocompleter

:100644 100644 16e9a35c4d... ffd3f7c023... M	desktop/core/src/desktop/static/desktop/js/autocomplete/globalSearchParser.js
:100644 100644 3b305494f9... 15a1bdf0c8... M	desktop/core/src/desktop/static/desktop/js/autocomplete/jison/globalSearchParser.jison
:100644 100644 e56d1530f8... cc322f06cf... M	desktop/core/src/desktop/static/desktop/js/autocomplete/sqlParseSupport.js
:100644 100644 dbdda9c92a... fec149d04d... M	desktop/core/src/desktop/static/desktop/spec/autocomplete/globalSearchParserSpec.js
:100644 100644 84615de11a... cd86780990... M	desktop/core/src/desktop/templates/ko_components.mako

commit c6f6148ddddc2837c62fa3e593d42fa9b681037f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 5 11:15:30 2017 +0200

    HUE-7362 [assist] Enable filter on column types in the left assist

:100644 100644 1918c11bb0... 1f7aa2f7e2... M	desktop/core/src/desktop/static/desktop/js/assist/assistDbEntry.js
:100644 100644 eb736a7e56... 16e9a35c4d... M	desktop/core/src/desktop/static/desktop/js/autocomplete/globalSearchParser.js
:100644 100644 b8c9a5dfc3... 3b305494f9... M	desktop/core/src/desktop/static/desktop/js/autocomplete/jison/globalSearchParser.jison
:100644 100644 90d07acaa5... e56d1530f8... M	desktop/core/src/desktop/static/desktop/js/autocomplete/sqlParseSupport.js
:100644 100644 d9865bf159... dbdda9c92a... M	desktop/core/src/desktop/static/desktop/spec/autocomplete/globalSearchParserSpec.js
:100644 100644 64a1a7a4be... 86774722ba... M	desktop/core/src/desktop/templates/assist.mako

commit 774b54a0b98e205e0023fab47cc307ce3817146d
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 4 16:42:13 2017 +0200

    HUE-7362 [assist] Use the new inline autocomplete input for assist filters
    
    With this the inline autocomplete component is used for SQL and Collections assist. It only has facets for sql views and tables at this point.

:100644 100644 68db00f684... fb2013041c... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 226afe4919... f0ce13da1a... M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 041ed52856... 1918c11bb0... M	desktop/core/src/desktop/static/desktop/js/assist/assistDbEntry.js
:100644 100644 43e932ab49... 14ce47831b... M	desktop/core/src/desktop/static/desktop/js/assist/assistDbSource.js
:100644 100644 e3b0ec9157... 10996a4b6d... M	desktop/core/src/desktop/static/desktop/less/hue-assist.less
:100644 100644 f2f2038b9c... 5a973b2ce3... M	desktop/core/src/desktop/static/desktop/less/hue.less
:100644 100644 88a629e0e9... 64a1a7a4be... M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 715460600d... 84615de11a... M	desktop/core/src/desktop/templates/ko_components.mako

commit 60509a48dfb50446d1fb0349abe19a94191f647f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 4 14:54:33 2017 +0200

    HUE-7362 [assist] Include free text parts in the query specification from the global search parser

:100644 100644 94640797f7... eb736a7e56... M	desktop/core/src/desktop/static/desktop/js/autocomplete/globalSearchParser.js
:100644 100644 86d1541895... b8c9a5dfc3... M	desktop/core/src/desktop/static/desktop/js/autocomplete/jison/globalSearchParser.jison
:100644 100644 016cc2202b... 90d07acaa5... M	desktop/core/src/desktop/static/desktop/js/autocomplete/sqlParseSupport.js
:100644 100644 152d1021d8... d9865bf159... M	desktop/core/src/desktop/static/desktop/spec/autocomplete/globalSearchParserSpec.js
:100644 100644 ff6752e4f8... 715460600d... M	desktop/core/src/desktop/templates/ko_components.mako

commit c9a68c66239cd4b9697955273d3f9b54a30f55cb
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 4 14:01:46 2017 +0200

    HUE-7362 [assist] Extract a generic inline autocomplete component
    
    The component handles the parsing and autocomplete operations given some facets, it will also autocomplete facet values and there's also a callback that can be used to autocomplete based on search results.

:100644 100644 3dc2e9fd09... 68db00f684... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 3dfb2467ae... f2f2038b9c... M	desktop/core/src/desktop/static/desktop/less/hue.less
:100644 100644 8316cbdb2f... ff6752e4f8... M	desktop/core/src/desktop/templates/ko_components.mako

commit 09babe3feca09302a22d20584c5303e65e1c6497
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Oct 4 11:23:27 2017 +0200

    HUE-7362 [assist] Extend the global search parser to also include the facet values in the parse results

:100644 100644 427e112741... 94640797f7... M	desktop/core/src/desktop/static/desktop/js/autocomplete/globalSearchParser.js
:100644 100644 33ac03ca36... 86d1541895... M	desktop/core/src/desktop/static/desktop/js/autocomplete/jison/globalSearchParser.jison
:100644 100644 2019cc4201... 016cc2202b... M	desktop/core/src/desktop/static/desktop/js/autocomplete/sqlParseSupport.js
:100644 100644 3807aa10c7... 152d1021d8... M	desktop/core/src/desktop/static/desktop/spec/autocomplete/globalSearchParserSpec.js
:100644 100644 4f71fbb44f... 8316cbdb2f... M	desktop/core/src/desktop/templates/ko_components.mako

Manual on Chrome + Jasmine

https://dl.dropbox.com/s/ufjxviedsorumrk/Screenshot%202017-10-05%2013.17.34.png?dl=0
https://dl.dropbox.com/s/kwifjzlpkd8c3ly/Screenshot%202017-10-05%2013.16.40.png?dl=0
https://dl.dropbox.com/s/j8vfhkbk73u7z2w/Screenshot%202017-10-05%2013.17.09.png?dl=0
https://dl.dropbox.com/s/nmjp76nhx4gdujo/Screenshot%202017-10-05%2013.35.37.png?dl=0

Johan Åhlén
Johan Åhlén
Romain Rigaux
Romain Rigaux
Johan Åhlén
Review request changed

Status: Closed (submitted)

Loading...