HUE-7062 [search] Add custom autocomplete parser for solr formulas

Review Request #11740 - Created Oct. 10, 2017 and submitted

Johan Åhlén
hue
master
hue
enricoberti, jgauthier, ranade, romain, weixia, yingc
commit 402006dc2fffe477ba9acf0872381239a4f59dfc
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Tue Oct 10 12:26:13 2017 +0200

    HUE-7062 [search] Add custom autocomplete parser for solr formulas

:100644 100644 e583ebeeeb... 1a783e0560... M	Gruntfile.js
:000000 100644 0000000000... cf055bf18b... A	desktop/core/src/desktop/static/desktop/js/autocomplete/jison/solrExpressionParser.jison
:000000 100644 0000000000... 30c6a06816... A	desktop/core/src/desktop/static/desktop/js/autocomplete/solrExpressionParser.js
:000000 100644 0000000000... 913bc66ba2... A	desktop/core/src/desktop/static/desktop/spec/autocomplete/solrExpressionParserSpec.js
:100644 100644 8a13bb5c1d... 4111affdb1... M	desktop/core/src/desktop/templates/jasmineRunner.html
:100755 100755 3b936d4347... e06982095c... M	tools/jison/hue-jison.sh

Manual on Chrome + Jasmine

This is just the parser part, it still needs to be plugged in in the UI.

  1. Ship It!
  2. 
      
  1. Nice!

    Is it type aware, e.g. avg on numeric types / function returning numeric only?
    Adding percentile(), unique() etc too?
    I guess we fo for the exact Solr syntax now (might be simpler/better long term to stay close to it even if bit less UX friendly for normal users)

    1. I still need to add a solr function library, I did it outside the parser for SQL to make it easier to maintain so will do similar for Solr. Once there it will be type aware and it will be the source when suggesting functions.

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...