HUE-6093 [frontend] Added support for basic Pie chart on Plotly

Review Request #11748 - Created Oct. 11, 2017 and submitted

Enrico Berti
hue
master
HUE-6093
hue
jgauthier, johan, ranade, romain, weixia, yingc
commit cacb3dc0c0d2d69c303950de26010f1160303960
Author: Enrico Berti <hello@enricoberti.com>
Date:   Wed Oct 11 12:15:14 2017 +0200

    HUE-6093 [frontend] Added support for basic Pie chart on Plotly

:100644 100644 bfcc6d310e... 1731c2f186... M	desktop/core/src/desktop/static/desktop/js/ko.charts.plotly.js
Manual on Chrome
  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
  1. Ship It!
  2. Nit: var HUE_CHARTS, no benefit of storing in ko as attr right?

    1. yeah this one is for retro compat with the other library

  3. Nit: drop the '_' as we don't do that elsewhere
    1. bueno, will do in the next commit!

  4. No need for this as timeout is cleared once it's fired......

    If you meant to dispose any previous timeouts on update you'd need to store the timeout in the element or something......

    1. just wrong how i did it, this betta:

      var plotterTimeout;
      window.clearTimeout(plotterTimeout);
      plotterTimeout = window.setTimeout(function () {
      console.log('banana').....

    2. this is betta:
      element.plotterTimeout

    3. You can do element.plotterTimeout? Me thought
      
      window.clearTimeout($(element).data('plotterTimeout'));
      $(element).data('plotterTimeout', window.setTimeout(...));
  5. 
      
  1. PS: one jira for each 4 types of charts instead of a massive one?

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...