HUE-7420 [jb] Impala Query integration

Review Request #11755 - Created Oct. 11, 2017 and submitted

Jean-Francois Desjeans Gauthier
hue
HUE-7248
HUE-7420
hue
jgauthier
commit 0ba615d593a7182009963edfa81b1ea088593814
Author: jdesjean <jgauthier@cloudera.com>
Date:   Wed Oct 11 16:46:10 2017 -0700

    HUE-7420 [jb] Impala Query integration

:100644 100644 9464b43845... 4faea332db... M	apps/impala/src/impala/server.py
:100644 100644 375b88444c... b503f32026... M	apps/jobbrowser/src/jobbrowser/api2.py
:100644 100644 814ff3086c... 0a783c9d3a... M	apps/jobbrowser/src/jobbrowser/apis/query_api.py
:100644 100644 0261eca142... 8c01ca3b7f... M	apps/jobbrowser/src/jobbrowser/templates/job_browser.mako
:100644 100644 37800079e0... 31c4fe9590... M	apps/jobbrowser/src/jobbrowser/urls.py


  • 1
  • 0
  • 15
  • 5
  • 21
Description From Last Updated
cf. comments about using 'active' class instead? Romain Rigaux
  1. Nice!!

    Quick comments!

  2. No () as would be a tuple

  3. CREATING --> RUNNING
    TERMINATING does not exist I think

  4. Not sure COMPLETED exists?

  5. Include only when the Query browser is enabled?

  6. Is should not be in livy-session-page but in queries-page ?

  7. Does not break Oozie or other job pages?

  8. 
      
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/templates/job_browser.mako (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    For larger functions it's better to add them to the viewmodel, it's easier to maintain and test

  3. apps/jobbrowser/src/jobbrowser/templates/job_browser.mako (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
  4. 
      
  1. Really nice, last nits!

  2. '' --> {}

    or it does not matter?

    1. Unfortunately, objects won't work here. Needs to be a primitive.

  3. def _memory... adding _ to those to avoid confusion with the public API?
  4. def query...
    def
    ..

    ?

  5. Did you 'git add' these files?

  6. <li class="active"> ?
    1. I cannot set this as active, because then tab('show') below doesn't work.

  7. <div class="tab-pane active"
    1. I cannot set this as active, because then tab('show') below doesn't work.

  8. apps/jobbrowser/src/jobbrowser/templates/job_browser.mako (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
  9. With the 'active' classes cf above we should not need it?

    1. I agree that this code is ugly, however I can't find a better way to do this.
      The "shown" event only gets called when tab("show") is called and only when the tab is not "active".
      I was looking for an init event, but outside of the binding initialization (which is not really the right place), couldn't find one.

  10. 
      
  1. Last one!

  2. cf. comments about using 'active' class instead?

    1. I agree that this code is ugly, however I can't find a better way to do this.
      The "shown" event only gets called when tab("show") is called and only when the tab is not "active".
      I was looking for an init event, but outside of the binding initialization (which is not really the right place), couldn't find one.

  3. 
      
  1. I see, let's go with it for a v1! (and Enrico/Johan might have an idea)

    1. And we probably can clean it in https://issues.cloudera.org/browse/HUE-6697

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...