HUE-7560 [assist] Re-use the new collections panel on the dashboard right assist

Review Request #11985 - Created Nov. 10, 2017 and submitted

Enrico Berti
hue
master
HUE-7560
hue
jgauthier, johan, ranade, romain, roohi, weixia, yingc
commit 6908d6b52c1be0306da1606b9fa86ed0fdf1088d
Author: Enrico Berti <hello@enricoberti.com>
Date:   Fri Nov 10 10:40:51 2017 +0100

    HUE-7560 [assist] Simplified loading of the right assist collection panel

:100644 100644 f43c2529fe... e9c2d234c7... M	desktop/core/src/desktop/templates/assist.mako

commit bafb129dfdd3294bf093662518b14f3246fe599a
Author: Enrico Berti <hello@enricoberti.com>
Date:   Fri Nov 10 10:33:08 2017 +0100

    HUE-7560 [assist] Fix filtering of fields in the right assist collection panel

:100644 100644 d30935ddc3... f43c2529fe... M	desktop/core/src/desktop/templates/assist.mako

commit ecd929323f09052d7f654eebfcb4f5132089ca3c
Author: Enrico Berti <hello@enricoberti.com>
Date:   Fri Nov 10 10:31:13 2017 +0100

    HUE-7560 [assist] Re-use the new collections panel on the dashboard right assist

:100644 100644 784723e33e... d30935ddc3... M	desktop/core/src/desktop/templates/assist.mako

Manual on Chrome

https://db.dropbox.com/s/i7skhvwi80rt199/Screenshot%202017-11-10%2010.53.50.png?dl=0

  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
  1. 
      
  2. desktop/core/src/desktop/templates/assist.mako (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    This should be extracted to a separate template instead and shared with the sql one, should be the same if assistDbEntry is used.

    1. So, the way I did this is that there are something things that are not necessary in the collection case, ie: having more than one collection at a time, visibleOnHover, or even open/close the collection... so I thought about saving a bit without having another foreachVisible. Bueno or should I refactor?

  3. Nit: Can skip highlightable as we only highlight in the left assist.

  4. 
      
Review request changed

Status: Closed (submitted)

Loading...