HUE-7654 [core] Integrate Threads page as page on /about page

Review Request #12050 - Created Nov. 20, 2017 and submitted

Roohi Syeda
hue
HUE-7774-Autocomplete
HUE-7654
hue
enricoberti, erickt, jgauthier, johan, romain, yingc
commit 9ec16e9fb143bcd9479dcdeaaa44f19aaaeec6ed
Author: Roohi <roohisyeda@cloudera.com>
Date:   Mon Nov 20 11:40:24 2017 -0800

    HUE-7654 [core] Integrate Threads page as page on /about page

:100644 100644 f41777b86c... 0c6a109b7c... M	desktop/core/src/desktop/templates/about_layout.mako
:100644 100644 f093c90656... c9c0dbfa75... M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 525c1b23fb... 44f258dabf... M	desktop/core/src/desktop/templates/threads.mako
:100644 100644 aa428d5dea... ed631a18d9... M	desktop/core/src/desktop/views.py

commit 4c8d9f11c38253e3ec64cb350172e7273f4ddd01
Author: Roohi <roohisyeda@cloudera.com>
Date:   Mon Nov 20 11:07:25 2017 -0800

    HUE-7654 [core] Integrate Threads page as page on /about page

:100644 100644 28528eea07... 525c1b23fb... M	desktop/core/src/desktop/templates/threads.mako

commit ef0238e29ef2e28d1a3e3b687d982c85fd491fb7
Author: Roohi <roohisyeda@cloudera.com>
Date:   Mon Nov 20 10:56:22 2017 -0800

    HUE-7654 [core] Integrate Threads page as page on /about page

:000000 100644 0000000000... 28528eea07... A	desktop/core/src/desktop/templates/threads.mako


  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
Seems weird, wasn't this test for the mako file and not rest? Could check for 'Threads' instead Romain Rigaux
The original test which was written before I started working on threads page was checking for the rest and not ... Roohi Syeda
  1. Nice!

  2. 
      
  1. Cool! Can you please squash all the commits in one? We tend to avoid pushing several commits with the same name/description

  2. 
      
  1. Please next time create a new review, you erased the content of the previous review..

  2. desktop/core/src/desktop/tests.py (Diff revision 2)
     
     

    Seems weird, wasn't this test for the mako file and not rest?

    Could check for 'Threads' instead

  3. 
      
  1. 
      
  2. desktop/core/src/desktop/tests.py (Diff revision 2)
     
     

    The original test which was written before I started working on threads page was checking for the rest and not for mako (There was no mako then). Do you want me to change it to test for mako page that is check for 'Threads' instead?

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...