[core] Integrate Metrics as page on /about page

Review Request #12136 - Created Dec. 1, 2017 and submitted

Roohi Syeda
hue
master
HUE-7691
hue
enricoberti, erickt, romain, yingc
commit ac678f771667938aa6b230a940a645ad4b9e2c94
Author: Roohi <roohisyeda@cloudera.com>
Date:   Thu Nov 30 09:42:58 2017 -0800

    [core] Integrate Metrics as page on /about page
    
    [core] Integrate Metrics as page on /about page—step2

:100644 100644 31a18c2f6b... 3446afc689... M	desktop/core/src/desktop/lib/metrics/views.py
:100644 100644 845011d4c9... 61fa876baf... M	desktop/core/src/desktop/templates/about_layout.mako
:100644 100644 e22aa7d1f3... 3cf8af6383... M	desktop/core/src/desktop/templates/hue.mako
:000000 100644 0000000000... b4ddc7c09a... A	desktop/core/src/desktop/templates/metrics.mako


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. Nice!

  2. Since the page is already KOified, instead of hiding/showing with JS, you could use a computed observable that checks for metricsFilter (so getting rid of the subscribe as weel) and use that in the foreach

    something like https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/templates/config_ko_components.mako#L161

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...