HUE-7718 [editor] Enable presentation mode just for SQL editors

Review Request #12142 - Created Dec. 4, 2017 and submitted

Enrico Berti
hue
master
HUE-7718
hue
jgauthier, johan, ranade, romain, roohi, weixia, yingc
commit 8a7db187603a77bc21f6b12060269989d6c567bc
Author: Enrico Berti <hello@enricoberti.com>
Date:   Mon Dec 4 13:20:29 2017 +0100

    HUE-7718 [editor] Enable presentation mode just for SQL editors

:100644 100644 7ff015cbd5... d76f8d8277... M	desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js
:100644 100644 82f1af81ef... 4754007155... M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
  1. Ship It!
  2. Nit: No need for typeof check

    You should do snippets().length === 1 as well as it would be odd with multi-snippet presentation mode.

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...