HUE-7727 [jb] Killed jobs do not get filtered correctly

Review Request #12150 - Created Dec. 4, 2017 and updated

Jean-Francois Desjeans Gauthier
hue
master
HUE-7727
hue
jgauthier

commit 4d349f5709142f10e19f464b2fff2b2e6605c46d
Author: jdesjean <jgauthier@cloudera.com>
Date: Mon Dec 4 13:09:41 2017 -0800

\[jb\] Killed jobs do not get filtered correctly

:100644 100644 69cf430f14... a22db22925... M apps/jobbrowser/src/jobbrowser/api.py

I did a quick test in C6 and oozie does not have this problem. The problem is still there C5.15. Either way, the logic still works.

  • 0
  • 0
  • 1
  • 3
  • 4
Description From Last Updated
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/api.py (Diff revision 1)
     
     

    Why adding 'FINISHED' to failed state? (seems incorrect)

    1. Killed jobs have a finalStatus of KILLED but a State of FINISHED.

  3. apps/jobbrowser/src/jobbrowser/api.py (Diff revision 1)
     
     

    Is the jira about failed jobs or failed tasks?

  4. 
      
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/api.py (Diff revision 1)
     
     

    So FAILED,KILLED does not exist?

    1. FAILED & KILLED do exist, but it depends how the job gets killed.
      Job can get killed in two ways:
      1) Yarn job is killed, State will be KILLED.
      2) Task is killed (which is what we do). Yarn job State is FINISHED, but finalStatus KILLED.
      The color is being determined by the finalStatus, the list of jobs is being determined by State so there is a mismatch. This was changed recently by you: https://github.com/cloudera/hue/commit/aa90cb8e11f3c5c7b3cb2f8e5fc2e05cb33ea55e. My guess is this was done so that we could filter multiple statuses on Yarn. However, that logic has the mismatch issue.

  3. apps/jobbrowser/src/jobbrowser/api.py (Diff revision 1)
     
     

    Update jira/review title?

    I thought this was about filtering killed tasks of a job.

  4. 
      
Review request changed

Testing Done:

  +

I did a quick test in C6 and oozie does not have this problem. The problem is still there C5.15. Either way, the logic still works.

Loading...