HUE-7806 [core] Show all the users "Switch to Hue 4" option

Review Request #12239 — Created Dec. 15, 2017 and submitted

roohi
hue
master
HUE-7806
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit c0410a8666d2a73e7e1dcd1c0cb237d00c794b60
Author: Roohi <roohisyeda@cloudera.com>
Date:   Fri Dec 15 13:35:34 2017 -0800

    HUE-7806 [core] Show all the users "Switch to Hue 4" option

:100644 100644 f06d548b1b... 9fc3717c93... M	desktop/core/src/desktop/templates/common_header.mako


  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
romain
  1. 
      
  2. % if view_profile or conf.IS_HUE_4.get():

    ?

    If for some reason we are still Hue 3 and no view_profile, we lose the full dropdown?

    1. Are you asking if we lose the full dropdown after my change or the change you are suggesting? We are still Hue 3 meaning conf.IS_HUE_4.get() is false and no view_profile meaning user doesn't have the permission? If so, I think yes we will lose the full dropdown.

    2. Yes, we should protect against losing the full drop down

    3. I got what you asked only now. So what should we show when both is_hue4 & view_profile are false? Show we remove the caret/dropdown or show Switch to Hue4 irrespective of is_hue4?

  3. 
      
roohi
  1. 
      
  2. I got what you asked only now. So what should we show when both is_hue4 & view_profile are false? Show we remove the caret/dropdown or show Switch to Hue4 irrespective of is_hue4?

    1. Would want to show the username and that's it (like before the change). Currently we would not display any username which would create more problems.

  3. 
      
roohi
romain
  1. Ship It!
  2. 
      
roohi
Review request changed

Status: Closed (submitted)

Loading...