HUE-7732 [editor] Support CTRL + S when inside a variable input

Review Request #12312 - Created Jan. 8, 2018 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-7732
hue
jgauthier
commit d16c62d6ccce6626991b06c49dd514d98488bcec
Author: jdesjean <jgauthier@cloudera.com>
Date:   Mon Jan 8 13:48:30 2018 -0800

    HUE-7732 Support CTRL + S when inside a variable input

:100644 100644 7ed1d5c84c... d893b65ccf... M	desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js
:100644 100644 70fba9311c... e07b89cdb0... M	desktop/libs/notebook/src/notebook/templates/editor_components.mako


  • 0
  • 0
  • 1
  • 2
  • 3
Description From Last Updated
  1. 
      
  2. nit: usuallt space after // and upper case first later

  3. In case of save there is no dialog, only in case of save as. Are we getting it even in case of regular save?

    1. On mac, cmd-s triggers native browser save dialog (not the hue one)

  4. 
      
  1. Nice!

    And good if we do a save and the query was not saved yet? (brings save as popup?) Even if not we could leave with this for now :)

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...