HUE-7847 [search] Show PK field in the right assist

Review Request #12329 - Created Jan. 10, 2018 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-7847
hue
jgauthier
commit b93178d35f5effd9427aa3ea30af05fd28d94383
Author: jdesjean <jgauthier@cloudera.com>
Date:   Wed Jan 10 15:48:47 2018 -0800

    HUE-7847 [search] Show PK field in the right assist

:100644 100644 b69d248531... f23fc93cc9... M	desktop/libs/libsolr/src/libsolr/api.py
:100644 100644 f276812354... 2c2d0b284f... M	desktop/libs/notebook/src/notebook/connectors/solr.py


  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
  1. Would this be a bit cleaner?

  2. desktop/libs/libsolr/src/libsolr/api.py (Diff revision 1)
     
     

    Do we need a:

    if response_json['schema'].get('uniqueKey'):

    if there is no pk?

  3. desktop/libs/libsolr/src/libsolr/api.py (Diff revision 1)
     
     

    field['primary_key'] = True

    1. I'm not sure why, but currently the front end is looking for the string 'true' and not the boolean true.

  4. primary_key': field.get('primary_key')

  5. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...