HUE-7861 [jb] Handle Impala query timeout

Review Request #12338 - Created Jan. 11, 2018 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-7861
hue
jgauthier
commit cde7bc75978fc376b569ad7475dca7b49de7d8ca
Author: jdesjean <jgauthier@cloudera.com>
Date:   Thu Jan 11 16:59:42 2018 -0800

    HUE-7861 [jb] Handle Impala query timeout

:100644 100644 a3910c0ccc... 602cf09e0b... M	apps/jobbrowser/src/jobbrowser/templates/job_browser.mako


  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
  1. 
      
  2. Need to look a bit more, but would just looking if we are not missing certain attributes enough? (wondering if we should not complexify the API just for that)

    1. When there is an error, no properties are changed @L1959. This makes it impossible to check if there's an error via the model. If you want to change the display, adding properties is the only solution.

    2. I'll take another look.

  3. 
      
  1. 
      
  2. Keep 'if callback'?

    Do we need to keep callback calling only if status is 0?

  3. apps/jobbrowser/src/jobbrowser/templates/job_browser.mako (Diff revision 2)
     
     
     
     
     
     

    Couldn't this fit in self._fetchJob?

    (and we have status == 0 and just a status string for the expired jobs)

    Or maybe even try/catch the issue in the Python API? (so that we avoid most of the logic change in the js)

  4. 
      
  1. Clean :)

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...