HUE-7873 [core] Update the AutoComplete for Document share in /home page

Review Request #12393 - Created Jan. 22, 2018 and submitted

Information
Roohi Syeda
hue
HUE-7774-Autocomplete
HUE-7873
Reviewers
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit 20a00a661ac6471c9d7e6b6b799cb382abba2925
Author: Roohi <roohisyeda@cloudera.com>
Date:   Mon Jan 22 15:36:46 2018 -0800

    HUE-7873 [core] Update the AutoComplete for Document share in /home page

:100644 100644 209bd902b4... 762f324bb1... M	desktop/core/src/desktop/static/desktop/css/hue-embedded.css
:100644 100644 952b663103... e2aab9c253... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 d31882c347... 5399fcef73... M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 b6d6e8e1a8... 1ef1b8143a... M	desktop/core/src/desktop/static/desktop/js/document/hueDocument.js
:100644 100644 5e1b4763f5... af27ccd347... M	desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
:100644 100644 19bc740ab9... b38f5bb377... M	desktop/core/src/desktop/static/desktop/js/share2.vm.js
:100644 100644 6718570f08... d3edec8932... M	desktop/core/src/desktop/static/desktop/less/hue-cross-version.less
:100644 100644 cb869c3c02... 587d70adf1... M	desktop/core/src/desktop/templates/common_share.mako
:100644 100644 76c87b8e81... 77ec6952c2... M	desktop/core/src/desktop/templates/document_browser.mako

  

Issues

  • 7
  • 20
  • 0
  • 27
Description From Last Updated
Why do we need this? the user object should already have a prettyName attribute after prettifyUserNames has been called Johan Åhlén Johan Åhlén
No need for return as the user object gets prettyName set Johan Åhlén Johan Åhlén
Why is this one needed? #ascrail2006 seems generated and a bit random Johan Åhlén Johan Åhlén
Do you have a screenshot of how this looks? Johan Åhlén Johan Åhlén
hueUtils.highlight Johan Åhlén Johan Åhlén
space after if: if (search... For consistency we always use brackets i.e. if (...) { return text; } Johan Åhlén Johan Åhlén
Nit: remove whitespace Johan Åhlén Johan Åhlén
Roohi Syeda
Roohi Syeda
Johan Åhlén
Johan Åhlén
Johan Åhlén
Roohi Syeda
Review request changed

Status: Closed (submitted)

Loading...