HUE-7758 [dashboard] Multi select and single select text facet

Review Request #12431 - Created Jan. 29, 2018 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-7758
hue
jgauthier
commit 4b2440e3ca8747bf2ad4150fb7411c7449187c1e
Author: jdesjean <jgauthier@cloudera.com>
Date:   Mon Jan 29 16:17:25 2018 -0800

    HUE-7758 [dashboard] Multi select and single select text facet

:100644 100644 89a0812b01... f77014c62e... M	desktop/libs/dashboard/src/dashboard/api.py
:100644 100644 3656160e4d... c6420e6ef8... M	desktop/libs/dashboard/src/dashboard/models.py
:100644 100644 77f3a81fbf... 7a4ff96efe... M	desktop/libs/dashboard/src/dashboard/static/dashboard/css/common_dashboard.css
:100644 100644 c7248eabe1... d54f1fdc48... M	desktop/libs/dashboard/src/dashboard/static/dashboard/css/search.css
:100644 100644 df9ab8740d... 0cdba61810... M	desktop/libs/dashboard/src/dashboard/static/dashboard/js/search.ko.js
:100644 100644 ffac95da68... 45814083fd... M	desktop/libs/dashboard/src/dashboard/static/dashboard/less/common_dashboard.less
:100644 100644 db50af0138... 603f52a643... M	desktop/libs/dashboard/src/dashboard/static/dashboard/less/search.less
:100644 100644 f1ae085f72... 57c8e465fd... M	desktop/libs/dashboard/src/dashboard/templates/common_search.mako


  • 0
  • 0
  • 4
  • 2
  • 6
Description From Last Updated
  1. Quick push to a test branch? (easier to play with)

  2. 
      
  1. Looks nice!

    Removing selection via Filter widget does not reset the dropdown?

  2. Here add 100 as limit?

  3. Any way to avoid this one?

  4. 
      
  1. Rebase on master and update the branch?

    Still in process to understand the core js changes

  2. 
      
  1. Ship It!
  2. Perhaps a bit neater with $parent.isFirstElement() or $root.isFirstElement($parent) etc.

  3. <label> to make it clickable
  4. 
      
Review request changed

Status: Closed (submitted)

Loading...