HUE-7946 [jb] Link to subworkflow on workflow dashboard page 404s in Hue 4

Review Request #12517 - Created Feb. 12, 2018 and submitted

Roohi Syeda
hue
HUE-7774-Autocomplete
HUE-7946
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit da1354afdc2864133316d4bc7a223687087fd043
Author: Roohi <roohisyeda@cloudera.com>
Date:   Mon Feb 12 14:39:45 2018 -0800

    HUE-7946 [jb] Link to subworkflow on workflow dashboard page 404s in Hue 4 (Fix regression in Hue 3)

:100644 100644 1c1bd37860... d7b9669856... M	apps/oozie/src/oozie/templates/editor2/common_workflow.mako

Manual on chrome Hue 3 & 4

  • 0
  • 0
  • 8
  • 0
  • 8
Description From Last Updated
  1. 
      
  2. Reopened HUE-7946. Found out that this fix actually causes regression in Hue 3 while back porting as it uses the same mako file. Also the expected thing to show when clicking on the icon is to open the sub workflow and not the logs for Hue 4

  3. 
      
  1. 
      
  2. How does $parent.externalIdUrl() look like exactly?

    Seems we could clean-it up properly in one shot or do it in the backend.

    Or instead of $parent.externalIdUrl() we could see if there is an external job id variable that we could reuse

  3. 
      
  1. 
      
  2. $parent.externalIdUrl() looks like for eg: /oozie/list_oozie_workflow/0000001-180308054124734-oozie-oozi-W/

    We are setting externalId as expected on python side but on JS side we are setting it to id
    https://github.com/cloudera/hue/blob/669dba05ff1c3d83b7a6a0e16d4b9fc4bff1a8a7/apps/oozie/src/oozie/templates/dashboard/list_oozie_workflow_graph.mako#L115

    which is of format eg: 0000000-180308054124734-oozie-oozi-W@subworkflow-3a55. Any suggestions?

  3. 
      
  1. 
      
  2. jobId --> externalJobId ?

  3. Ha, here we actually uses id instead of externalId (fine to keep it like that as too dangerous to change)

  4. apps/oozie/src/oozie/views/dashboard.py (Diff revision 2)
     
     

    externalJobId ?

  5. 
      
Review request changed

Status: Closed (submitted)

Loading...