HUE-7980 [editor] Enable presentation mode button just if the editor is not empty

Review Request #12520 - Created Feb. 13, 2018 and submitted

Information
Enrico Berti
hue
master
HUE-7980
Reviewers
hue
jgauthier, johan, ranade, romain, roohi, weixia, yingc
commit f372fec523e800adfa44a93a137e36ea48e18ae7
Author: Enrico Berti <hello@enricoberti.com>
Date:   Tue Feb 13 10:25:24 2018 +0100

    HUE-7980 [editor] Enable presentation mode button just if the editor is not empty

:100644 100644 a8fcb54524... 13225baa5c... M	desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js
:100644 100644 4d5301a623... b0e8e59019... M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
Manual on Chrome

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
Nit: self.statement_raw.subscribe(notebook.isPresentationModeAvailable) Johan Åhlén Johan Åhlén
... or pureComputed ... or just use notebook.statement_raw in the dom.... Johan Åhlén Johan Åhlén
Johan Åhlén
Enrico Berti
Review request changed

Status: Closed (submitted)

Loading...