HUE-7980 [editor] Enable presentation mode button just if the editor is not empty

Review Request #12520 - Created Feb. 13, 2018 and submitted Feb. 15, 2018, 5:18 a.m.

Information
Owner:	Enrico Berti
Repository:	hue
Branch:	master
Bugs:	HUE-7980
Depends On:
Reviewers
Groups:	hue
People:	jgauthier, johan, ranade, romain, roohi, weixia, yingc

Description

commit f372fec523e800adfa44a93a137e36ea48e18ae7
Author: Enrico Berti <hello@enricoberti.com>
Date:   Tue Feb 13 10:25:24 2018 +0100

    HUE-7980 [editor] Enable presentation mode button just if the editor is not empty

:100644 100644 a8fcb54524... 13225baa5c... M	desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js
:100644 100644 4d5301a623... b0e8e59019... M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

Testing Done

Manual on Chrome

Issues

2
0
0
0
All Issues: 2

Description	From	Last Updated
Nit: self.statement_raw.subscribe(notebook.isPresentationModeAvailable)	Johan Åhlén	Feb. 13, 2018, 6:28 a.m.
... or pureComputed ... or just use notebook.statement_raw in the dom....	Johan Åhlén	Feb. 13, 2018, 6:28 a.m.

Ship it! Fix it!

```
Ship It!
```

desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js (Diff revision 1)

Show all issues

Nit: self.statement_raw.subscribe(notebook.isPresentationModeAvailable)

Enrico Berti Feb. 13, 2018, 6:39 a.m.

that's cleaner but then we shouldn't treat isPresentationModeAvailable as boolean (since statement_raw is a string or null), let me get rid of the var and move the check to the DOM

desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js (Diff revision 1)
Show all issues
```
... or pureComputed ... or just use notebook.statement_raw in the dom....
```

You have a pending review.

Review Board 3.0.3

HUE-7980 [editor] Enable presentation mode button just if the editor is not empty

Status: Closed (submitted)