HUE-8006 [home] Document sharing inconsistencies

Review Request #12551 — Created Feb. 16, 2018 and submitted

roohi
hue
HUE-7774-Autocomplete
HUE-8006
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit a2d684ddecc913991e8605fb7e414e694f440339
Author: Roohi <roohisyeda@cloudera.com>
Date:   Fri Feb 16 16:14:39 2018 -0800

    HUE-8006 [home] Document sharing inconsistencies

:100644 100644 1de527ef84... f3491b03eb... M	desktop/core/src/desktop/static/desktop/js/document/hueFileEntry.js
:100644 100644 52bc2e5e97... 793a84a81a... M	desktop/core/src/desktop/static/desktop/js/home2.vm.js
:100644 100644 84cfc89d18... 492fea95fc... M	desktop/core/src/desktop/templates/assist.mako


  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
johan
  1. 
      
  2. desktop/core/src/desktop/templates/assist.mako (Diff revision 1)
     
     
     
     
     
     
     

    A better approach is to fetch the user groups on demand using ajax. It does not belong in the AssistDocumentsPanel

  3. 
      
roohi
  1. 
      
  2. desktop/core/src/desktop/templates/assist.mako (Diff revision 1)
     
     
     
     
     
     
     

    I followed the way it was done here
    https://github.com/cloudera/hue/blob/6567d592067548ee935508446a1364d0bd84799c/desktop/core/src/desktop/templates/common_home.mako#L72 for another code path. I didn't find any server side api to get the groups of a user. Do you suggest adding one? If so, is adding to HueFileEntry.js file a good place?

    1. It's just odd that the AssistDocumentsPanel would have this attribute. I'd say it should either be a global js constant or created where needed. But it's ok to leave it here for now as the share model needs quite some cleaning up and we can revisit later.

    2. Thanks Johan. I will put it in global js constant.

  3. 
      
roohi
johan
  1. Ship It!
  2. 
      
roohi
Review request changed

Status: Closed (submitted)

Loading...