Need to retain DeadServers to ensure we don't allow previously expired RS instances to rejoin cluster
Review Request #1259 - submitted 3 years, 3 months ago
We currently let go of dead servers once we finish their shutdown. We should hang on to them longer to deal with things like network partitions. I'm not a fan of SoftReferences so I decided on another approach. DeadServers now has a maximum number of servers to hold on to in the set (default 100). Once it reaches the max, it evicts the oldest. More code than I had hoped but nothing too crazy.
Running unit tests now.
Review request changed
Updated 3 years, 3 months ago (November 29th, 2010, 11:43 a.m.)
- added Diff r2
Makes DeadServers private. It was still accessed by my TestRollingRestart test so I had to make a small change to how that worked. Also added some additional testing in TestDeadServers that verifies the new boolean check works as expected and also that the max capacity works as expected.