HUE-8069 [core] Pyformance reporter thread stops on exceptions in guage callbacks

Review Request #12639 - Created March 13, 2018 and submitted

Roohi Syeda
hue
HUE-7774-Autocomplete
HUE-8069
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit 507ecbef8ba7515aaca961f096f4ed12f40f7cac
Author: Roohi <roohisyeda@cloudera.com>
Date:   Tue Mar 13 15:13:32 2018 -0700

    HUE-8069 [core] Pyformance reporter thread stops on exceptions in guage callbacks

:100644 100644 04277f2088... 9e4bd1c47a... M	desktop/core/src/desktop/metrics.py

Manual

  • 2
  • 0
  • 1
  • 0
  • 3
Description From Last Updated
Could you move this to line #26 with 2 new lines above/below (like we do elsewhere, we always declare constants ... Romain Rigaux
except: LOG.exception('Metrics: Failed to get number of user accounts') Is enough as LOG.exception alreayd logs the trace, here we will ... Romain Rigaux
  1. 
      
  2. desktop/core/src/desktop/metrics.py (Diff revision 1)
     
     

    Could you still log the problem? e.g.

    try:
    ...
    except:
    LOG.exception(..)

    return users

  3. 
      
  1. +1 to ship after previous comment done

  2. 
      
Review request changed

Status: Closed (submitted)

  1. 
      
  2. desktop/core/src/desktop/metrics.py (Diff revision 2)
     
     

    Could you move this to line #26 with 2 new lines above/below (like we do elsewhere, we always declare constants on top)

  3. desktop/core/src/desktop/metrics.py (Diff revision 2)
     
     

    except:
    LOG.exception('Metrics: Failed to get number of user accounts')

    Is enough as LOG.exception alreayd logs the trace, here we will double log the exception

  4. 
      
Loading...