HUE-8177 [oozie] Add a config check for /user/hue/oozie/workspaces

Review Request #12786 - Created April 5, 2018 and updated

Roohi Syeda
hue
HUE-7774-Autocomplete
HUE-8177
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit 55dc30eadfaa6556a569685bd13f3b6a45cb8293
Author: Roohi <roohisyeda@cloudera.com>
Date:   Thu Apr 5 15:50:10 2018 -0700

    HUE-8177 [oozie] Add a config check for "/user/hue/oozie/workspaces"

:100644 100644 5112a72ea7... 01b10f64a6... M	apps/oozie/src/oozie/conf.py

Tested manually on chrome

  • 8
  • 0
  • 0
  • 0
  • 8
Description From Last Updated
Should work on top as desktop is the core lib? Romain Rigaux
Romain, you suggested me to add in liboozie, but I have import issues with REMOTE_SAMPLE_DIR so added in oozie app ... Roohi Syeda
Waht it still a problem when importing like on line 116? Romain Rigaux
If none or does not exist, could we add a warning too? Romain Rigaux
nit: NICE_NAME, nit: we usually " ... %s ... are too restrictive" % EMOTE_SAMPLE_DIR.get() Romain Rigaux
Can't be on top? Romain Rigaux
Could we move to #82? Romain Rigaux
Should we add a live or mock test (this could be tricky)? e.g. TestFileBrowserWithHadoop in filebrowser app Romain Rigaux
  1. 
      
  2. apps/oozie/src/oozie/conf.py (Diff revision 1)
     
     

    Romain, you suggested me to add in liboozie, but I have import issues with REMOTE_SAMPLE_DIR so added in oozie app for now. I am not very familiar with importing. Can you pls help me resolve.

  3. 
      
  1. Nice, just a few nits

  2. apps/oozie/src/oozie/conf.py (Diff revision 1)
     
     

    Should work on top as desktop is the core lib?

  3. apps/oozie/src/oozie/conf.py (Diff revision 1)
     
     

    Waht it still a problem when importing like on line 116?

  4. apps/oozie/src/oozie/conf.py (Diff revision 1)
     
     

    If none or does not exist, could we add a warning too?

  5. apps/oozie/src/oozie/conf.py (Diff revision 1)
     
     
    nit:
    NICE_NAME, <space>
    
    nit:
    
    we usually " ... %s  ... are too restrictive" % EMOTE_SAMPLE_DIR.get()
  6. 
      
Review request changed

Change Summary:

Moved validation to liboozie

Diff:

Revision 2 (+19)

Show changes

  1. 
      
  2. Can't be on top?

  3. Could we move to #82?

  4. desktop/libs/liboozie/src/liboozie/conf.py (Diff revision 2)
     
     
     

    Should we add a live or mock test (this could be tricky)?

    e.g. TestFileBrowserWithHadoop in filebrowser app

    1. I am trying to follow TestFileBrowserWithHadoop. How do I run TestFileBrowserWithHadoop tests?

  5. 
      
Loading...