HUE-8187 [doc] Add Instrumentation flag and log format documentation to upstream documentation

Review Request #12853 — Created April 17, 2018 and submitted

roohi
hue
HUE-8118_log_mmeory
HUE-8187
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit cf3f129a24693482caae9c6c96ef2d67dc6970cf
Author: Roohi <roohisyeda@cloudera.com>
Date:   Tue Apr 17 15:41:47 2018 -0700

    HUE-8187 [doc] Add Instrumentation flag and log format documentation to upstream documentation

:100644 100644 2da42cefab... 9ebb880b5a... M	docs/admin-manual/manual.md


  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
enricoberti
  1. Ship It!
  2. 
      
romain
  1. 
      
  2. docs/admin-manual/manual.md (Diff revision 1)
     
     
    Add config in plain text instead? e.g.
    
    <pre>
    [desktop]
    instrumentation=true
    </pre>
  3. docs/admin-manual/manual.md (Diff revision 1)
     
     
    Wrap around <pre></pre>?
  4. docs/admin-manual/manual.md (Diff revision 1)
     
     

    'returned in 97ms ' is present all the time

    1. https://github.com/cloudera/hue/blob/7590c0b16e2378fc0c76b8df20273c43caf3fec5/desktop/core/src/desktop/log/access.py#L101.
      According to the code I added, request time is appended only when instrumentation is enabled. Do you want me to fix the code first?

    2. +1 to indeed show all the time the time (it is pretty cheap and was already printing it)

  5. 
      
roohi
roohi
roohi
Review request changed

Status: Closed (submitted)

Loading...