HUE-8232 [oozie] Fix 500 error if coordinator associated workflow has been deleted

Review Request #12874 - Created April 20, 2018 and submitted

Ying Chen
hue
origin/master
HUE-8232
hue
enricoberti, jgauthier, johan, ranade, romain, weixia
commit 4d25b903218d7101561b29a145d3da0242de2dce (HEAD -> HUE-8232-coor)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Fri Apr 20 13:34:14 2018 -0700

    HUE-8232 [oozie] Fix 500 error if coordinator associated workflow has been deleted

:100644 100644 0537f8b86b... 3ab2cc9ac8... M    apps/oozie/src/oozie/static/oozie/js/coordinator-editor.ko.js
:100644 100644 5ac2a3f58b... d08c65e097... M    apps/oozie/src/oozie/templates/editor2/common_scheduler.inc.mako
:100644 100644 f84c96f2ac... dfdbe6ffcd... M    apps/oozie/src/oozie/views/editor2.py
Manual
  • 0
  • 0
  • 3
  • 1
  • 4
Description From Last Updated
  1. Do we really need the UI changes? Seems like we could just do it at the python level and keep it simpler.

    1. Yes, it throws binding error getWorkflowById(coordinator.properties.workflow()).name in JavaScript console.
    2. And spinning keep rest of the page loading.
  2. The convention is to always have curly brackets in ifs

  3. apps/oozie/src/oozie/views/editor2.py (Diff revision 1)
     
     

    Document2.DoesNotExist, e:

    cleaner?

  4. 
      
  1. 
      
  2. Would just doing this be enough?

    <!-- ko if: getWorkflowById(coordinator.properties.workflow() -->

  3. apps/oozie/src/oozie/views/editor2.py (Diff revision 2)
     
     

    (document.name if document.name else '')

    -->

    document.name if document.name else ''

  4. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Loading...