HUE-8273 [filebrowser] Support white spaces in filenames

Review Request #12924 - Created May 2, 2018 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-8273
hue
jgauthier
commit 7fbc1a5f98c26797edf53c2d60d0ceb2221af38d
Author: jdesjean <jgauthier@cloudera.com>
Date:   Wed May 2 14:41:59 2018 -0700

    HUE-8273 [filebrowser] Support white spaces in filenames

:100644 100644 df0331d994... a50875ff64... M	apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 bedfd45263... 5bc468b91c... M	apps/filebrowser/src/filebrowser/urls.py
:100644 100644 0faaaa9bee... 36846fbce8... M	apps/filebrowser/src/filebrowser/views.py
:100644 100644 0f68fc7a7e... d9ede3b9c2... M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 945b53f556... 571eed6aa2... M	desktop/libs/indexer/src/indexer/indexers/sql.py
:100644 100644 6f4f6482a1... 78cad74f55... M	desktop/libs/notebook/src/notebook/api.py
:100644 100644 443cf8cb38... 5d13db4931... M	desktop/libs/notebook/src/notebook/connectors/hiveserver2.py
:100644 100644 a1704e43b4... 19f06596ea... M	desktop/libs/notebook/src/notebook/models.py


  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
  1. Should we have a quick test, e.g. https://github.com/cloudera/hue/blob/master/apps/filebrowser/src/filebrowser/views_test.py#L752?

  2. How come . does not include whitespaces?

    1. "." does not include white spaces. Hence, need to add \s\S.

  3. nit: keep the new line?

  4. apps/filebrowser/src/filebrowser/views.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    nit: bit risky, we are sure we are doing with urls all the time?

  5. 
      
Review request changed

Status: Closed (submitted)

Loading...