HUE-8282 [fb] Check if EC2 instance before check IAM metadata

Review Request #12935 - Created May 7, 2018 and submitted May 16, 2018, 4:24 p.m.

Information
Owner:	Ying Chen
Repository:	hue
Branch:	origin/master
Bugs:	HUE-8282
Depends On:
Reviewers
Groups:	hue
People:	enricoberti, jgauthier, johan, ranade, romain, weixia

Description

commit 3dd40a9013b76bffaf987bac395477e760198be3 (HEAD -> HUE-8282-s3)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Mon May 7 18:23:18 2018 -0700

    HUE-8282 [fb] Check if EC2 instance before check IAM metadata

:100644 100644 ae8656c05d... 50eb5b40c0... M    desktop/libs/aws/src/aws/conf.py

Testing Done

Tested on Mac, vpc, and gce

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
except Exception, e:	Romain Rigaux	May 9, 2018, 1:19 p.m.
No need to ': %s" % e LOG.error --> LOG.except	Romain Rigaux	May 9, 2018, 1:19 p.m.

Branch:

+	master

Bugs:

+	HUE-8282

Ship it!

```
Ship It!
```

Description:

~		commit ffb8d5fbff24aef361242cab02eccc27284ce2f9 (HEAD -> HUE-8282-s3)
	~	commit 3dd40a9013b76bffaf987bac395477e760198be3 (HEAD -> HUE-8282-s3)
		Author: Ying Chen yingchen@cloudera.com
		Date: Mon May 7 18:23:18 2018 -0700

		HUE-8282 [fb] Check if EC2 instance before check IAM metadata

~		:100644 100644 ae8656c05d... 19bc0eaa94... M desktop/libs/aws/src/aws/conf.py
	~	:100644 100644 ae8656c05d... 50eb5b40c0... M desktop/libs/aws/src/aws/conf.py

Branch:

-	master
+	origin/master

Diff:

Revision 2 (+10 -2)

Show changes

desktop/libs/aws/src/aws/conf.py

Ship it!

desktop/libs/aws/src/aws/conf.py (Diff revision 2)
Show all issues
```
except Exception, e:
```

desktop/libs/aws/src/aws/conf.py (Diff revision 2)

Show all issues

No need to ': %s" % e

LOG.error --> LOG.except

Ying Chen May 9, 2018, 1:21 p.m.

Just want to have a unique with the general exception, so that quickly identify where it happened.

Diff:

Revision 3 (+10 -2)

Show changes

desktop/libs/aws/src/aws/conf.py

You have a pending review.

Review Board 3.0.3

HUE-8282 [fb] Check if EC2 instance before check IAM metadata

Branch:

Bugs:

Description:

Branch:

Diff:

Diff:

Status: Closed (submitted)