Django Upgrade work

Review Request #12936 - Created May 10, 2018 and updated

Prakash Ranade
hue
django-upgrade-test1
hue
enricoberti, jgauthier, johan, ranade, romain, roohi, subrata, weixia, yingc
commit 61315819ec28a15bd6a8221f5a0a487f92586f0e
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Tue May 1 16:45:15 2018 -0700

    changing to text as in the initial phase Location is not resolvable

:100644 100644 ae8656c05d... 15a9d04b3b... M	desktop/libs/aws/src/aws/conf.py

commit c6d02dadbf90778161146f2221bb414c57d30a37
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Wed Mar 21 03:24:40 2018 +0530

    setup Python2.7 installation
    
    Fixing python2.7 shebang issue when virtual_bootstrap --relocatable runs
    Moving Python installation from /opt/cloudera to /usr/local due to http://github.mtv.cloudera.com/CDH/cdh/blob/cdh6.x/lib/python/cauldron/src/cauldron/tools/buildparcel.py#L686
    Enabling /opt/rh/python27/root/usr/bin/python through scl tool
    Adding Python2.7 enabling script
    adding python version line
    adding test change

:100644 100644 74f95c20d0... 0eed483b77... M	Makefile
:100644 100644 4d745b0910... f2960618b7... M	Makefile.tarball
:100644 100644 c1a64ef283... c867564bc4... M	Makefile.vars
:000000 100755 0000000000... 42e6488cdb... A	tools/enable-python27.sh
:100644 100644 f578962b76... c31d3300f6... M	tools/relocatable.sh
:100755 100755 42cd1f4b01... 4c11ef92a7... M	tools/virtual-bootstrap/virtual-bootstrap.py

commit 18f41cbfb14110e53051116ae77451d90dd4ef1b
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Mar 19 22:50:47 2018 -0700

    fixing claimed_id issue in migrations

:100644 100644 c8bb23c89d... 244cec0576... M	desktop/core/ext-py/django-openid-auth-0.14/django_openid_auth/migrations/0001_initial.py
:100644 100644 f2035f35b8... f4e37dd39e... M	desktop/core/ext-py/django-openid-auth-0.14/django_openid_auth/south_migrations/0001_initial.py
:100644 100644 335794f1da... ff8582415c... M	desktop/core/ext-py/django-openid-auth-0.14/django_openid_auth/south_migrations/0002_add_perm_account_verified.py

commit 28eeaeb0bcc77c23711ffd09d38c1bdf76ae2064
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Mar 19 19:05:46 2018 -0700

    Fixing test desktop.management.commands.test.setup_test_environment

:100644 100644 a2e018fd67... 94953b2e2d... M	desktop/core/src/desktop/management/commands/test.py

commit 341545047d9109ac1851922fd40f8b778bdda7b2
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Mar 19 17:23:53 2018 -0700

    Fixing Beeswax test

:100644 100644 b47a806268... f72c3ce7a8... M	apps/beeswax/src/beeswax/tests.py

commit 3adb032c87879525e351442ea29ed24289395879
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Sat Mar 17 19:11:06 2018 -0700

    adding Enum related fixes
    fixing test

:100644 100644 ef7533cc1a... 6b3f95ac60... M	apps/beeswax/src/beeswax/templates/list_history.mako
:100644 100644 a81ac0f5ab... 3be6b1a537... M	apps/beeswax/src/beeswax/templates/my_queries.mako
:100644 100644 f688d8d3d2... b47a806268... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 47f35d37d5... 68be842e2c... M	apps/useradmin/src/useradmin/middleware.py
:100644 100644 250254ce28... a4be887e3a... M	apps/useradmin/src/useradmin/old_migrations/0002_add_ldap_support.py
:100644 100644 d29685517d... bd23af2435... M	apps/useradmin/src/useradmin/test_ldap.py
:100644 100644 56a3d5eee4... 59916eb402... M	apps/useradmin/src/useradmin/test_ldap_deprecated.py
:100644 100644 5f8807c070... 61316468ee... M	apps/useradmin/src/useradmin/views.py
:100644 100644 7e6682d62f... 06c7e0c9c5... M	desktop/core/src/desktop/auth/backend.py
:100644 100644 d168d2bede... be7d821bbd... M	desktop/libs/liboauth/src/liboauth/backend.py
:100644 100644 c6927adeb3... c5682dc224... M	desktop/libs/libopenid/src/libopenid/backend.py
:100644 100644 618b821a64... bae1892daf... M	desktop/libs/libsaml/src/libsaml/backend.py

commit 11c7d60a8240998b83f793456c4d9cecc52aeb2f
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Sat Mar 17 16:49:33 2018 -0700

    Upgrading Enum34 module

:100644 100644 2cce98729b... a7a1101af4... M	apps/beeswax/src/beeswax/management/commands/close_queries.py
:100644 100644 530c48ee81... 6b63e1884e... M	apps/beeswax/src/beeswax/models.py
:100644 100644 0968d64849... b420470c28... M	apps/beeswax/src/beeswax/server/dbms.py
:100644 100644 577231f036... ef7533cc1a... M	apps/beeswax/src/beeswax/templates/list_history.mako
:100644 100644 b531817ca6... a81ac0f5ab... M	apps/beeswax/src/beeswax/templates/my_queries.mako
:100644 100644 6ab04a6b0a... f688d8d3d2... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 d9fa133bd8... f1fd37a881... M	apps/beeswax/src/beeswax/views.py
:100644 100644 1e0b96f912... a0f2e01018... M	apps/impala/src/impala/tests.py
:100644 100644 aff4bc3a67... 0deb00eae9... M	apps/rdbms/src/rdbms/api.py
:100644 100644 33ed585431... ae5fee887d... M	apps/useradmin/src/useradmin/models.py
:100644 100644 0078fae0f3... 5a6831f06c... M	desktop/libs/librdbms/src/librdbms/server/dbms.py
:100644 100644 2357f95d26... 67a4a045ff... M	desktop/libs/notebook/src/notebook/connectors/hiveserver2.py

commit fe2399872d6ce9bfe523449d852794cdea1ade50
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Tue Mar 13 19:15:32 2018 -0700

    Fixing useradmin.tests
    
    Adding fixes
    adding change
    adding fix for the response.status_code in test_share_workflow

:100644 100644 3ae28bba9a... 414cf23a84... M	apps/oozie/src/oozie/tests.py
:100644 100644 935885489d... d20120c617... M	apps/useradmin/src/useradmin/forms.py
:100644 100644 66df9a9e8d... 33ed585431... M	apps/useradmin/src/useradmin/models.py
:100644 100644 0a47680769... a822f46248... M	apps/useradmin/src/useradmin/tests.py
:100644 100644 7197955f27... 3e2203c362... M	desktop/core/src/desktop/auth/views_test.py
:100644 100644 37fd1f97f3... 3e70be2dba... M	desktop/core/src/desktop/models.py
:100644 100644 4c17f22b93... cab9bd6088... M	desktop/core/src/desktop/tests.py

commit 5ddb0dd55f08b976cab0c1ee9362e2df0298f53e
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Wed Mar 7 13:31:14 2018 -0800

    Fixing metrics chicken-egg issue for the migration

:100644 100644 9fc4a4da89... 4b9a86377c... M	apps/useradmin/src/useradmin/metrics.py

commit 0949cc1231d90f66066b3ca4055285e761e4cc00
Author: Romain Rigaux <romain@cloudera.com>
Date:   Fri Mar 2 15:39:02 2018 -0800

    [core] Move util location_to_url to desktop lib utils

:100644 100644 26cb079be4... 0968d64849... M	apps/beeswax/src/beeswax/server/dbms.py
:100644 100644 18fbc4eca1... 63b57fae54... M	apps/filebrowser/src/filebrowser/views_test.py
:100644 100644 17b9614698... 5ffad3ed69... M	apps/jobbrowser/src/jobbrowser/models.py
:100644 100644 1845a6abf4... 752b4af2bf... M	apps/jobbrowser/src/jobbrowser/templates/job.mako
:100644 100644 64e80bedcc... 7e66c9c1e9... M	apps/metastore/src/metastore/views.py
:100644 100644 41e4fd7c35... a60f9eec2e... M	desktop/core/src/desktop/lib/view_util.py

commit 1c4fc0d92c98063f0addec9900c57e1ffba43d94
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Fri Mar 2 11:25:45 2018 -0800

    Fixing metrics initial run

:100644 100644 379fa7d565... 502bf7b797... M	desktop/core/src/desktop/lib/metrics/file_reporter.py

commit bb849463faab49a877ff46d72d778018deb0142d
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Tue Feb 27 13:45:32 2018 -0800

    Removing monkey patching for User
    Adding handle_noargs changes

:100644 100644 b81cc35431... 6ad2e04c01... M	apps/oozie/src/oozie/management/commands/oozie_setup.py
:100644 100644 10af42c8aa... 7292c0ef20... M	apps/oozie/src/oozie/views/editor.py
:100644 100644 f68af1b89c... 431a405952... M	apps/pig/src/pig/management/commands/pig_setup.py
:100644 100644 53d7e141b4... 592e030123... M	apps/pig/src/pig/views.py
:100644 100644 53905c9b64... f5228660f5... M	apps/search/src/search/management/commands/search_setup.py
:100644 100644 19e2266d8d... 362a81652b... M	apps/search/src/search/views.py
:100644 100644 36f55715da... e4afa03559... M	apps/useradmin/src/useradmin/old_migrations/0008_convert_documents.py
:100644 100644 f560002a12... 105145f8ad... M	desktop/core/src/desktop/management/commands/config_dump.py
:100644 100644 872ec42fe6... 5ef99d5ec7... M	desktop/core/src/desktop/management/commands/config_help.py
:100644 100644 333c7b87a3... a088b55992... M	desktop/core/src/desktop/management/commands/convert_documents.py
:100644 100644 68a866ab37... 34f575bb65... M	desktop/core/src/desktop/management/commands/create_test_fs.py
:100644 100644 9106bb15cb... 1c120b2aeb... M	desktop/core/src/desktop/management/commands/generate_mdl.py
:100644 100644 4add555859... 450be8bf15... M	desktop/core/src/desktop/management/commands/is_db_alive.py
:100644 100644 c03762618f... 571a7eaaf1... M	desktop/core/src/desktop/management/commands/kt_renewer.py
:100644 100644 9c80aa0d04... e89a348619... M	desktop/core/src/desktop/management/commands/ldaptest.py
:100644 100644 25348f5b18... 91b9c34c51... M	desktop/core/src/desktop/management/commands/sync_documents.py
:000000 100644 0000000000... ca0c0b6c4f... A	desktop/core/src/desktop/management/commands/syncdb.py
:100644 100644 2c3bad7735... a5ae39c80c... M	desktop/core/src/desktop/management/commands/version.py
:100644 100644 26dbd80c20... be57b22931... M	desktop/libs/notebook/src/notebook/urls.py

commit 6eccccc346924e9a99b08319e4125f0092f62f23
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Feb 19 14:59:50 2018 -0800

    Adding change

:100644 100644 33c1443dcf... 637e233e6a... M	desktop/Makefile

commit fc1af5f30bda5b9872f6fa4dcfa73887e4dd3162
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Feb 12 16:35:01 2018 -0800

    adding change

:100644 100644 f8336e5f95... 74f95c20d0... M	Makefile

commit 41c4cc3422c654eeb7e1f078b8ccaa2931173a5d
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Feb 5 09:46:30 2018 -0800

    Fixing make install

:100644 100644 f24cb683d3... 33c1443dcf... M	desktop/Makefile

commit ce1bfd1688f6701eaf98dfa5dce1d1d0d9df463f
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Thu Feb 1 14:31:19 2018 -0800

    Adding /opt/cloudera/python/ for RedHat 6 environment

:100644 100644 5f9dc52145... c1a64ef283... M	Makefile.vars

commit fecc4110aa15df852599bc8a6ceea34564c73889
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Jan 8 11:50:40 2018 -0800

    To upgrade Django 1.11, following changes are needed:
    
    - Adding Context Processor change
    - replacing LocalTimezone with get_current_timezone
    - Fixing authentication issue
    - commenting out axes.middleware.FailedLoginMiddleware
    - adding reverse for filebrowser.views.view
    - Adding reverse url fixes
    - adding proper fix for authenticate method in desktop/auth/backend.py
    - adding name keyword argument repeated fix
    - Fixing reverse url name property
    - Adding fixes for authenticate, user.username, etc
    - Adding Reverse url name property
    - fixing reverse url and upgrading ipdb, ipython, pylint, astroid, isort, six
    - upgrading virtualenv
    - fixing order
    - fixing two things. 1>DateTimeField auto_now=True, 2>ImpersonationBackend authenticate is fixed
    - django_test_util create_model
    - reformating django_util.encode_json output
    - models.SubfieldBase is now depricated
    - south.modelsinspector is now depricated
    - reformating x.my_struct output
    - use use_natural_foreign_keys instead use_natural_keys -capture_output is boolean
    - Switching to Django based Pagination
    - Fixing response.context
    - fixing authenticate function
    - adding fix for oozie jobs
    - Fixing NoReverseMatch issue, request.POST.get
    - replacing request.POST[ to request.POST.get(
    - improving authenticate function

:100644 100644 14762f28da... 6bd37c7bbc... M	apps/beeswax/src/beeswax/api.py
:100644 100644 aaeed07a69... 530c48ee81... M	apps/beeswax/src/beeswax/models.py
:100644 100644 0617c35aa5... b8433e2645... M	apps/beeswax/src/beeswax/templates/beeswax_components.mako
:100644 100644 fc227e9210... abc589a876... M	apps/beeswax/src/beeswax/templates/list_designs.mako
:100644 100644 e4fc37584d... 577231f036... M	apps/beeswax/src/beeswax/templates/list_history.mako
:100644 100644 11409f4f9c... b531817ca6... M	apps/beeswax/src/beeswax/templates/my_queries.mako
:100644 100644 8ab1046218... 6ab04a6b0a... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 2f6d5a848c... d9fa133bd8... M	apps/beeswax/src/beeswax/views.py
:100644 100644 c1670002f3... addacbc9eb... M	apps/filebrowser/src/filebrowser/templates/display.mako
:100644 100644 2857301a96... ed8321410c... M	apps/filebrowser/src/filebrowser/templates/edit.mako
:100644 100644 aee9ea51b5... 26126264ed... M	apps/filebrowser/src/filebrowser/templates/listdir_components.mako
:100644 100644 1f8c5d9e45... efb4c27203... M	apps/filebrowser/src/filebrowser/templates/saveas.mako
:100644 100644 b203864424... 049f15b019... M	apps/filebrowser/src/filebrowser/views.py
:100644 100644 cddd12f41f... 18fbc4eca1... M	apps/filebrowser/src/filebrowser/views_test.py
:100644 100644 661ec29f18... 9980d93876... M	apps/help/src/help/urls.py
:100644 100644 de204a4ece... 1e0b96f912... M	apps/impala/src/impala/tests.py
:100644 100644 ca5cca657e... bd59e96be4... M	apps/jobbrowser/src/jobbrowser/api.py
:100644 100644 1ba3238918... e4fe7c7840... M	apps/jobbrowser/src/jobbrowser/templates/attempt.mako
:100644 100644 e9fa15dcc1... 1845a6abf4... M	apps/jobbrowser/src/jobbrowser/templates/job.mako
:100644 100644 e0c71c5d76... d04c2bad89... M	apps/jobbrowser/src/jobbrowser/templates/job_attempt_logs.mako
:100644 100644 1bc2121f99... 67e33183c1... M	apps/jobbrowser/src/jobbrowser/templates/task.mako
:100644 100644 3a73f0df10... e9cf6a2d1f... M	apps/jobbrowser/src/jobbrowser/templates/tasks.mako
:100644 100644 801ac1c902... 3ea70fd804... M	apps/jobbrowser/src/jobbrowser/tests.py
:100644 100644 33a48a0b4c... 8bafb69512... M	apps/jobbrowser/src/jobbrowser/urls.py
:100644 100644 2d6e3ae68b... ea2710eab4... M	apps/jobbrowser/src/jobbrowser/views.py
:100644 100644 e868e6c9a5... 4544269a4a... M	apps/jobsub/src/jobsub/static/jobsub/templates/designs.html
:100644 100644 9246fa7ed4... 99b64a6f5f... M	apps/jobsub/src/jobsub/tests.py
:100644 100644 71b95eb07f... b39660fab5... M	apps/jobsub/src/jobsub/urls.py
:100644 100644 f4386e578c... 9946a11950... M	apps/metastore/src/metastore/tests.py
:100644 100644 7d64a59e48... d7fe928dd6... M	apps/oozie/src/oozie/forms.py
:100644 100644 f6e6f439ff... 67fc7239b7... M	apps/oozie/src/oozie/models.py
:100644 100644 89a8f87e82... a4f652f57e... M	apps/oozie/src/oozie/models2_tests.py
:100644 100644 7de74a393d... 7212cbdb11... M	apps/oozie/src/oozie/templates/editor/create_coordinator.mako
:100644 100644 82e094b585... 6dc03dbf87... M	apps/oozie/src/oozie/templates/editor/edit_coordinator.mako
:100644 100644 6d5f0c6fc7... acb83bc7f6... M	apps/oozie/src/oozie/templates/editor/gen/bundle.xml.mako
:100644 100644 d076b2d7e5... 1172494126... M	apps/oozie/src/oozie/templates/editor/import_coordinator.mako
:100644 100644 730491de48... 3ae28bba9a... M	apps/oozie/src/oozie/tests.py
:100644 100644 c5f23b7e8c... 69232862c3... M	apps/oozie/src/oozie/views/dashboard.py
:100644 100644 7a4c7138aa... 10af42c8aa... M	apps/oozie/src/oozie/views/editor.py
:100644 100644 31e63e1db4... 9f8579dc29... M	apps/proxy/src/proxy/urls.py
:100644 100644 9d97dc194e... 19e2266d8d... M	apps/search/src/search/views.py
:100644 100644 f8d277c643... b7b3303455... M	apps/security/src/security/api/hive.py
:100644 100644 9b8bdd49dc... 32a23384a4... M	apps/security/src/security/api/sentry.py
:100644 100644 724abac236... 235eadaef7... M	apps/sqoop/src/sqoop/api/job.py
:100644 100644 60d617562d... 50b9abff79... M	apps/sqoop/src/sqoop/api/link.py
:100644 100644 cc6abb5e7d... 66df9a9e8d... M	apps/useradmin/src/useradmin/models.py
:100644 100644 392ed275fc... d29685517d... M	apps/useradmin/src/useradmin/test_ldap.py
:100644 100644 a768110773... 56a3d5eee4... M	apps/useradmin/src/useradmin/test_ldap_deprecated.py
:100644 100644 5e9d971a8e... 0a47680769... M	apps/useradmin/src/useradmin/tests.py
:100644 100644 d877136c02... ed08188997... M	apps/useradmin/src/useradmin/urls.py
:100644 100644 7f0826c644... d689a90dca... M	desktop/core/ext-py/Django-1.11/django/template/context.py
:100644 100644 785c077e15... 2884c508cf... M	desktop/core/src/desktop/api.py
:100644 100644 8ed26dca9b... 982f24651c... M	desktop/core/src/desktop/api2.py
:100644 100644 43ff70812a... 16bd8cb81a... M	desktop/core/src/desktop/api_tests.py
:100644 100644 25ecd2534d... 7e6682d62f... M	desktop/core/src/desktop/auth/backend.py
:100644 100644 cdd0e10052... 3594a25b32... M	desktop/core/src/desktop/auth/forms.py
:100644 100644 3561ae1ec6... 91c706ee60... M	desktop/core/src/desktop/auth/views.py
:100644 100644 b8c337e004... 7197955f27... M	desktop/core/src/desktop/auth/views_test.py
:100644 100644 34d1f61741... 52f6bfa507... M	desktop/core/src/desktop/converter_tests.py
:100644 100644 6cdc50d63a... a10199e7fe... M	desktop/core/src/desktop/lib/django_forms.py
:100644 100644 70cab1c685... ec6ca25f1e... M	desktop/core/src/desktop/lib/django_test_util.py
:100644 100644 13fd13c1d2... d7b8fa8317... M	desktop/core/src/desktop/lib/django_util.py
:100644 100644 aed91cd3c3... 49dd0f79e3... M	desktop/core/src/desktop/lib/django_util_test.py
:100644 100644 6c7e367439... 78ced36287... M	desktop/core/src/desktop/lib/djangothrift.py
:100644 100644 2a2eb94fc0... 72128abc7e... M	desktop/core/src/desktop/lib/djangothrift_test.py
:100644 100644 e039980de6... 4afda06930... M	desktop/core/src/desktop/lib/metrics/urls.py
:100644 100644 d7a3b11094... 627794ec6c... M	desktop/core/src/desktop/middleware_test.py
:100644 100644 c607a40690... d39ad3907b... M	desktop/core/src/desktop/require_login_test.py
:100644 100644 2ededbd9a3... 0817ebf867... M	desktop/core/src/desktop/settings.py
:100644 100644 9a4c60377c... 65acf41358... M	desktop/core/src/desktop/templates/common_tree.mako
:100644 100644 f5dd6a0a9f... 4c17f22b93... M	desktop/core/src/desktop/tests.py
:100644 100644 83f227fc43... fdea076cd3... M	desktop/core/src/desktop/views.py
:100644 100644 6faccd4ee9... a3c67bbc45... M	desktop/libs/dashboard/src/dashboard/api.py
:100644 100644 c63d714794... e88b9d38e2... M	desktop/libs/dashboard/src/dashboard/tests.py
:100644 100644 64b451fcbc... e620addf8f... M	desktop/libs/hadoop/src/hadoop/fs/fs_for_testing.py
:100644 100644 015344990f... 61ae07aa10... M	desktop/libs/indexer/src/indexer/views.py
:100644 100644 58a0d6a646... 03497c66e1... M	desktop/libs/liboozie/src/liboozie/utils.py
:100755 100755 e6c7576061... 1024099783... M	tools/jenkins/jenkins.sh
:100644 100755 b10945e734... 42cd1f4b01... M	tools/virtual-bootstrap/virtual-bootstrap.py
:000000 100644 0000000000... dfef51d448... A	tools/virtual-bootstrap/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
:100644 000000 be9238d94c... 0000000000... D	tools/virtual-bootstrap/virtualenv_support/pip-6.0.8-py2.py3-none-any.whl
:000000 100644 0000000000... 4b8ecc69db... A	tools/virtual-bootstrap/virtualenv_support/pip-9.0.1-py2.py3-none-any.whl
:100644 000000 978cf6c434... 0000000000... D	tools/virtual-bootstrap/virtualenv_support/setuptools-12.0.5-py2.py3-none-any.whl
:000000 100644 0000000000... 502e3cb418... A	tools/virtual-bootstrap/virtualenv_support/setuptools-28.8.0-py2.py3-none-any.whl
:000000 100644 0000000000... 506d5e520f... A	tools/virtual-bootstrap/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl


  • 0
  • 0
  • 15
  • 2
  • 17
Description From Last Updated
  1. 
      
  2. Makefile (Diff revision 1)
     
     
     

    Remove? (or fix)

  3. apps/beeswax/src/beeswax/models.py (Diff revision 1)
     
     
  4. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
  5. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
  6. apps/beeswax/src/beeswax/tests.py (Diff revision 1)
     
     
  7. No need to encode the url?

    1. @johan This change was made as part of https://review.cloudera.org/r/12924/. I'm guessing we're seeing the change because the base of the diff doesn't include the latest. Any reason why we shouldn't encode?

  8. apps/filebrowser/src/filebrowser/views.py (Diff revision 1)
     
     
     
     
     
     
  9. apps/jobsub/src/jobsub/tests.py (Diff revision 1)
     
     
  10. apps/oozie/src/oozie/forms.py (Diff revision 1)
     
     

    nit: coordinator_workflow

    1. the "coordinator.workflow" was conflicting so chose "coordinator.coordinatorworkflow"

  11. coordinator.workflow was cleaner IMO, why the change?

    1. the "coordinator.workflow" was conflicting somewhere so chose "coordinator.coordinatorworkflow"

  12. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
  13. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     

    Same. In general for all SkipTest, either remove test if not relevant, fix it or add a TODO.

  14. apps/useradmin/src/useradmin/tests.py (Diff revision 1)
     
     

    Delete.

  15. desktop/core/ext-py/Django-1.11/django/template/context.py (Diff revision 1)
     
     
     
     
     
     
     

    Delete or TODO

  16. desktop/core/src/desktop/settings.py (Diff revision 1)
     
     

    delete or fix?

  17. Nit: Red stuff.

  18. Nit: same.

  19. 
      
Loading...