HUE-8330 [notebook] Refactor Dataeng API

Review Request #13030 - Created June 6, 2018 and submitted

Romain Rigaux
hue
master
HUE-8330
hue
enricoberti, jgauthier, johan, ranade, roohi, weixia, yingc
commit 3e8425b5c4b06393d3414631e4260e8f72ac2e83
Author: Romain Rigaux <romain@cloudera.com>
Date:   Tue Jun 5 15:25:27 2018 -0700

    HUE-8330 [notebook] Refactor Dataeng API

:100644 100644 2205539... 8cb7a08... M	apps/oozie/src/oozie/static/oozie/js/workflow-editor.ko.js
:100644 100644 7e8326e... b16a2ff... M	apps/oozie/src/oozie/templates/editor2/workflow_editor.mako
:100644 100644 042d893... 956f15c... M	desktop/core/src/desktop/api2.py
:100644 100644 9048a5c... ddc30dd... M	desktop/libs/notebook/src/notebook/connectors/altus.py
:100644 100644 230cbc0... 258f20d... M	desktop/libs/notebook/src/notebook/connectors/dataeng.py

manual

  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
Why not: self.availableNamespaces = ko.observableArray(); ContextCatalog.getNamespaces({ sourceType: 'oozie' }).done(self.availableNamespaces); and self.availableComputes = ko.observableArray(); ContextCatalog.getComputes({ sourceType: 'oozie' }).done(self.availableComputes); Johan Åhlén
Also, selectize binding is no good for the data, go with: Johan Åhlén
  1. Ship It!
  2. Why not:
    
    self.availableNamespaces = ko.observableArray();
    
    ContextCatalog.getNamespaces({ sourceType: 'oozie' }).done(self.availableNamespaces);
    
    
    and
    
    
    self.availableComputes = ko.observableArray();
    
    ContextCatalog.getComputes({ sourceType: 'oozie' }).done(self.availableComputes);
  3. Also, selectize binding is no good for the data, go with:
    
    <div data-bind="component: { name: 'hue-drop-down', params: { value: compute, entries: availableComputes, labelAttribute: 'name', searchable: true, linkTitle: '${ _ko('Active compute') }' } }"></div>
  4. 
      
Review request changed

Status: Closed (submitted)

Loading...