HUE-8403 [pig] Hue3 Jobdesigner does not allow user to save parameter/argument

Review Request #13128 - Created June 27, 2018 and updated

Roohi Syeda
hue
HUE-8403_pig_jd_hue3
HUE-8403
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit cbcb2699fb7a6ed70695a64ffc0bd0d758919b11
Author: Roohi <roohisyeda@cloudera.com>
Date:   Wed Jun 27 13:20:23 2018 -0700

    HUE-8403 [pig] Hue3 Jobdesigner does not allow user to save parameter/argument

:100644 100644 f3bb2dcae5... 297557a11f... M	apps/oozie/src/oozie/utils.py


  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Sample params value [{"value":"param=param","type":"param"},{"value":"arg=arg","type":"argument"}] Roohi Syeda
  1. 
      
  2. apps/oozie/src/oozie/utils.py (Diff revision 1)
     
     

    Sample params value
    [{"value":"param=param","type":"param"},{"value":"arg=arg","type":"argument"}]

    1. Last time I had to change something here, Romain hinted this probably wasn't the right approached. He mentioned there's probabably some arguments missing in the UI. Can you take a look at https://review.cloudera.org/r/12180/

    2. Thanks JF. This bug got introduced as part of the fix, CDH-41448, which assumes that the JSON fields of type dictionary always has a property 'name' and since 'params' JSON field doesn't have property 'name', the params field is never saved.
      Where as the fix for advanced parameters, JSON field name : parameters (not params) sample is like this [{"name": "oozie.use.system.libpath", "value": "true"}]. Anyway as you suggested, I will wait for Romain to review the fix.

    3. I don't remembder the exact logic, +1 to JF but this is a corner case with the Job Designer of Hue 1 for Pig scripts, very rare to use so +1 for c5 only and that's it.

  3. 
      
  1. If it is a corner case in Hue 3 Job Designer, +1 to ship but not in master and only cdh5? (as Hue 4 only with the new Pig Editor in the Editor)

  2. 
      
Loading...