Fish Trophy

Roohi Syeda got a fish trophy!

HUE-8391 [importer] Improve Create table from File UX when loading data from parent directory not readable by hive/impala

Review Request #13131 - Created June 27, 2018 and submitted

Roohi Syeda
hue
HUE-8253_query_dwld_non_ascii
HUE-8391
hue
enricoberti, jgauthier, johan, ranade, romain, weixia, yingc
commit b16a4fa2da0bade87558350591282a2836fa7524
Author: Roohi <roohisyeda@cloudera.com>
Date:   Wed Jun 27 20:02:10 2018 -0700

    HUE-8391 [importer] Improve Create table from File UX when loading data from parent directory not readable by hive/impala

:100644 100644 021b7f0f62... c5ccbe5508... M	desktop/libs/indexer/src/indexer/api3.py


  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
  1. Would it fail with S3?

    We can uncheck the load data in step 2, so maybe we should only warn here, not error out? (similar message to when the table name already exists on step 2)

  2. More generic: "In order to load the data, parent path %(path)s would need to be writable by %(apiHelperType)s user or 777" ?

  3. 
      
  1. 
      
  2. nit: Move between line 23?
    (as it is an official import)

  3. nit: can keep new line

  4. 1. Only doing it when we want to import the data and the table is not external?
    
    if destination['importData'] and not destination['useDefaultLocation'] ...
    
    2. nit, might work:
     split.scheme in ['','hdfs'] --> not destination['isObjectStore']
    
    3.
    nit: space and tuple
    
    ('', 'hdfs')
  5. 
      
  1. 
      
  2. Should we do a move and not a copy too?

    1. I don't see any move method in webhdfs.py. Also, won't we be getting the same permission issues we started with, incase the user doesn't have write permissions?

    2. Move is like Unix, it is 'rename'. Permission level should not be an issue as typically people upload their own files (and copy can timeout if it is a large file).

  3. 
      
Review request changed

Status: Closed (submitted)

Loading...