HUE-6869 [editor] Add Impala language reference to the right assist

Review Request #13147 - Created July 5, 2018 and submitted

Johan Åhlén
hue
master
hue
enricoberti, jgauthier, ranade, romain, roohi, weixia, yingc
commit a1b95676c7d306f367fd365649f5462dad826153
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jul 5 13:05:18 2018 +0200

    HUE-6869 [editor] Add a config flag to enable the language reference
    
    The generated file is about 1.4 MB at this point, until split and fetched async the flag is disabled by default. Enable by:
    
    [desktop]
      enable_sql_language_ref=true

:100644 100644 10681c867c... c5dc76e8e8... M	desktop/conf.dist/hue.ini
:100644 100644 e1212b14df... 5353f6d884... M	desktop/conf/pseudo-distributed.ini.tmpl
:100644 100644 53bfe2af1d... fc611a57dc... M	desktop/core/src/desktop/conf.py
:100644 100644 e18b1ffd2e... 55e54b2129... M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 584552cef4... e215f9b60a... M	desktop/core/src/desktop/templates/global_js_constants.mako
:100644 100644 bd6b86c34b... 23fcb3421c... M	desktop/core/src/desktop/templates/hue.mako

commit 3fd779856ad4eaa381bbdcd65088c5283d24cbaf
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jul 5 12:55:29 2018 +0200

    HUE-6869 [editor] Enable internal links in the language reference details

:100644 100644 51cfbec246... d1d811e2a6... M	desktop/core/src/desktop/static/desktop/css/hue-embedded.css
:100644 100644 c65a13a009... 93d6e08458... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 219ab064b3... 31c6367b5b... M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 cac52ceb06... 06c6960f7b... M	desktop/core/src/desktop/static/desktop/js/sqlImpalaLangRef.js
:100644 100644 db803241c3... 8f7578c34d... M	desktop/core/src/desktop/static/desktop/less/hue-assist.less
:100644 100644 65fc8c8a55... e18b1ffd2e... M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 218d55ee09... 51f098f99e... M	tools/sql-docs/impalaExtractor.js

commit 28d0c3d47ca839fe284c05e2d6af7c16ee702f7e
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jul 5 11:17:43 2018 +0200

    HUE-6869 [editor] Add Impala language reference to the right assist
    
    The language reference is generated by running "node tools/sql-docs/impalaExtractor.js" in the hue folder.

:100644 100644 7057534ded... 51cfbec246... M	desktop/core/src/desktop/static/desktop/css/hue-embedded.css
:100644 100644 1c3d32071d... c65a13a009... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 34cdefcffb... 219ab064b3... M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 51f63869e6... f91fc6b2dc... M	desktop/core/src/desktop/static/desktop/css/login.css
:000000 100644 0000000000... cac52ceb06... A	desktop/core/src/desktop/static/desktop/js/sqlImpalaLangRef.js
:100644 100644 a90d2c6a40... db803241c3... M	desktop/core/src/desktop/static/desktop/less/hue-assist.less
:100644 100644 cfcadd239c... 65fc8c8a55... M	desktop/core/src/desktop/templates/assist.mako
:100644 100644 7572ec8de3... bd6b86c34b... M	desktop/core/src/desktop/templates/hue.mako
:100644 100644 217c610e26... 42f6ca94ec... M	package-lock.json
:100644 100644 089cf1fcf9... 278cf7d481... M	package.json
:000000 100644 0000000000... 218d55ee09... A	tools/sql-docs/impalaExtractor.js

Manual on Chrome

https://dl.dropbox.com/s/o2orh1r8k535ojh/HUE-6869.Impala_lang_ref_assist.rev1.mp4?dl=0

Note: sqlImpalaLangRef.js is generated by running "node tools/sql-docs/impalaExtractor.js" in the hue folder and should thus be ignored for this review.

The file is quite big, 1.4 MB. I think the best approach is to split it into multiple json files later and fetch them async on demand instead.

It's behind a config flag so to enable:

[desktop]
enable_sql_language_ref=true

  1. Nice! Ship it! \,,/(^_^)\,,/

    At a certain point we should also have video tutorials in Hue

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...