HUE-348. When FilterInput updates a zebra table, update the zebras

Review Request #1319 — Created Dec. 20, 2010 and submitted

shawn
old-hue-rw
HUE-348
hue
marcus, Thomas
commit 108f94026c56916f7df6ca7e222866efbdb0fa78
Author: Shawn Van Ittersum <shawn@cloudera.com>
Date:   Fri Dec 17 14:50:58 2010 -0800

    HUE-348. When FilterInput updates a zebra table, update the zebras

:100644 100644 ca4f2ab... 2e6fd69... M	desktop/core/static/js/Source/BehaviorFilters/Behavior.FilterInput.js
:000000 100644 0000000... b87d25f... A	desktop/core/static/js/Source/BehaviorFilters/Behavior.InputFilterHtmlTableZebra.js
:100644 100644 6bb0ae2... 0164737... M	desktop/core/static/js/Source/CCS/CCS.JFrame.js
:100644 100644 41774f1... 61f0cce... M	desktop/core/static/js/package.yml
Safari only
shawn
Review request changed

Change Summary:

Added a plug-in to trigger zebra update on HTML table when filtered.  Assisted by nutron.

Would prefer that all components which are to be filtered (e.g. HtmlTable) support a standard filtering interface, and each such component class handles its own filter specifics such as zebra stripe updating.

Testing Done:

  +

Safari only

marcus
  1. Looks pretty good to me.  The only thing I'd say is that the name of the event.."filtered"...seems that it should be "filter", as event handlers are usually referred to as on(eventName) handlers.  onFiltered doesn't make much sense to me, though onFilter does.  I think that name matches more with the names that I see in other places as well.  
    
    I also initially thought twice about the idea of this event being fired on the element...now that I think about it seems like a good method of communication between filters and their plugins, since by definition they have to refer to the same element.
    1. Agreed on the event name. Shawn and I wrote this together, but I chose that name without much thought...
  2. 
      
Loading...