HUE-8522 [jb] Make paused tasks more obvious. Add queued state to Impala

Review Request #13289 - Created Aug. 27, 2018 and submitted

Jean-Francois Desjeans Gauthier
hue
master
HUE-8522
hue
jgauthier
commit e8949bccc8509adfce0f7f3f764234b5f184e869
Author: jdesjean <jgauthier@cloudera.com>
Date:   Mon Aug 27 11:56:23 2018 -0700

    HUE-8522 [jb] Make paused tasks more obvious. Add queued state to Impala

:100644 100644 04c54bf930... 719fc3f5ea... M	apps/jobbrowser/src/jobbrowser/apis/query_api.py
:100644 100644 a39dcae57d... a877d39d3a... M	apps/jobbrowser/src/jobbrowser/static/jobbrowser/js/impala_dagre.js
:100644 100644 21f4dc1d46... de9ff9683e... M	apps/jobbrowser/src/jobbrowser/templates/job_browser.mako
:100644 100644 025babefa1... e09acfbd51... M	desktop/core/src/desktop/static/desktop/css/hue-embedded.css
:100644 100644 3be3e76ce5... e29b594f9c... M	desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 d2496080f8... 60260c2a2d... M	desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:100644 100644 7aaf29fd2e... f2bbb3a38b... M	desktop/core/src/desktop/static/desktop/less/hue-cross-version.less
:100644 100644 6b19ca5924... 27ebdc1ac1... M	desktop/libs/notebook/src/notebook/static/notebook/css/notebook.css
:100644 100644 80377553fa... 4023f5a9c8... M	desktop/libs/notebook/src/notebook/static/notebook/less/notebook.less
:100644 100644 c0f8526eab... 7f4ba1f8fd... M	desktop/libs/notebook/src/notebook/templates/editor_components.mako

https://drive.google.com/file/d/1DwjB_6ZquKzsch2V0H2X1ipccpku93er/view?usp=sharing

  • 2
  • 0
  • 3
  • 2
  • 7
Description From Last Updated
It feels a bit odd to use 'warning' for when it's running, that's more 'info' to me. How about we ... Johan Åhlén
Nit: Add -X /'*.css' to the review generation script to skip the generated .css files in the review. Johan Åhlén
  1. Nice! A few comments on trying to keep things not too complicated

  2. Could we avoid complicating the logic with lastEvent?

  3. Here add a note that 'Queued' is only supported here and not in Workflows, Coordinators, YARN etc... and will be sees as 'Running' in the end user fiters?

  4. Same, could we avoid adding another status state with lastEvent?

  5. Looks fishy to add this?

    1. Impala queries are considered opened/running until they are closed so we can't just look at the status. Separating the queries makes it easier for the users to know which of the queries can be closed in the UI.

  6. 
      
  1. Ship It!
  2. It feels a bit odd to use 'warning' for when it's running, that's more 'info' to me. How about we switch it around, make the paused ones warning and use info for running?

    1. My thinking is this: something that is "RUNNING" is hot, yellow / orange are hot colors. Something that is "PAUSED" is cold, blue is a cold color.
      Although, we could make a case that something that needs attention should be orange. I'm not agains't changing it, but not sure it's the right call.

    2. That being said, there's not much the user can do with a queue query except wait.

  3. Nit: Add -X /'*.css' to the review generation script to skip the generated .css files in the review.
  4. 
      
  1. We should probably keep things like they are now as it is simpler. If we really want to manage the pending state, most of the parts are there and we could:

    https://github.com/cloudera/hue/blob/master/desktop/libs/notebook/src/notebook/connectors/hiveserver2.py#L289 returning a 'starting'
    and we already manage it there https://github.com/cloudera/hue/blob/master/desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js#L1845

    and we could change the progress bar color when we are 'starting' and keep the back and forth like we do when the execute query has not returned yet. But beware as changing the core logic without introducing bugs can be very tricky.

    But at this point seems like there are more important items to do?

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...