HUE-8608 [useradmin] Add config check on number of documents

Review Request #13413 — Created Oct. 2, 2018 and submitted

yingc
hue
master
HUE-8608
hue
enricoberti, jgauthier, johan, ranade, romain, weixia
commit 5416a54fb3d682dd0bbaafef584bd6f90cfc14ae (HEAD -> master)
Author: Ying Chen <yingchen@cloudera.com>
Date:   Sat Oct 6 15:21:08 2018 -0700

    HUE-8608 [useradmin] Add config check on number of documents

:100644 100644 b220d09f34... d11dda9259... M    desktop/core/src/desktop/conf.py
:100644 100644 585e2c2105... 4728cb6471... M    desktop/core/src/desktop/settings.py


  • 0
  • 0
  • 4
  • 1
  • 5
Description From Last Updated
romain
  1. 
      
  2. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Confirm with Chris 30k? Would rather be a bit more conservative and do 50 or 75?

    1. Chris agree 50k should be a good start
  3. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Document2.objects.count() --> doc2_count

    30k --> %()s % doc2_count

  4. 
      
yingc
romain
  1. 
      
  2. desktop/core/src/desktop/conf.py (Diff revision 2)
     
     

    %d more than 30k entries

    -->

    more than %s entries: %s " % (MAX_ENTRIES, doc2_count)

    ..

  3. 
      
yingc
yingc
cconner
  1. Ship It!
  2. 
      
romain
  1. Two nits

  2. desktop/core/src/desktop/conf.py (Diff revision 4)
     
     

    FI: why -10000?

    1. Following command "hue desktop_document_clean": https://github.com/cloudera/hue/blob/master/desktop/core/src/desktop/management/commands/desktop_document_cleanup.py#L129

  3. desktop/core/src/desktop/conf.py (Diff revision 4)
     
     
     
     

    Why not split this in two ifs? (to keep it clear, as in one case it could be about the sessions)

  4. 
      
yingc
romain
  1. Ship It!
  2. 
      
yingc
yingc
Review request changed

Status: Closed (submitted)

Loading...