johan got a fish trophy!
HUE-8621 [editor] Add keyboard shortcut to toggle dark mode
Review Request #13431 — Created Oct. 10, 2018 and submitted
| Information | |
|---|---|
| johan | |
| hue | |
| master | |
| Reviewers | |
| hue | |
| jgauthier, ranade, romain, roohi, weixia, yingc | |
commit 092ff62c3e07cae69e93651dc4c2499c499bdd1f
Author: Johan Ahlen <johan@johanahlen.com>
Date: Wed Oct 10 12:58:50 2018 +0200
HUE-8621 [editor] Add keyboard shortcut to toggle dark mode
Ctrl/Cmd-Alt-T
:100644 100644 12ae521435 c690d6499a M desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
commit c29dd90fc19018d966c988c19327e6015411986a
Author: Johan Ahlen <johan@johanahlen.com>
Date: Wed Oct 10 12:54:02 2018 +0200
HUE-8621 [editor] Add ace option to toggle dark mode
This also persists the setting in total storage
:100644 100644 323ff5c53e 12ae521435 M desktop/core/src/desktop/static/desktop/js/ko.hue-bindings.js
commit 9e10a1104c386dc0cdb86beb3acdfb050ea1d175
Author: Johan Ahlen <johan@johanahlen.com>
Date: Wed Oct 10 12:44:51 2018 +0200
HUE-8621 [editor] Add a custom Ace mode for the dark theme
:100644 100644 8ddd43a0ff 54d57a9023 M desktop/core/src/desktop/static/desktop/css/hue-embedded.css
:100644 100644 32ee053af7 d120fe16cc M desktop/core/src/desktop/static/desktop/css/hue.css
:100644 100644 88fad91904 011a3cc210 M desktop/core/src/desktop/static/desktop/css/hue3-extra.css
:000000 100644 0000000000 25846c1830 A desktop/core/src/desktop/static/desktop/js/ace/theme-hue_dark.js
:100644 100644 108013cf4c e47f364bb3 M desktop/core/src/desktop/static/desktop/less/hue-cross-version.less
:000000 100644 0000000000 f5946309e1 A tools/ace-editor/lib/ace/theme/hue_dark.css
:000000 100644 0000000000 facddb3252 A tools/ace-editor/lib/ace/theme/hue_dark.js
Manual on Chrome
https://dl.dropboxusercontent.com/s/99s0nilqkkkzxr6/HUE-8621.Editor_dark_mode.mp4?dl=0
