HUE-8621 [editor] Add dark mode keyboard shortcut to the editor help

Review Request #13440 - Created Oct. 15, 2018 and submitted Oct. 17, 2018, 9:18 a.m.

Information
Owner:	Johan Åhlén
Repository:	hue
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	hue
People:	jgauthier, ranade, romain, roohi, weixia, yingc

Description

commit 5a2480a7d2497ea23f182901ac4c2dc8c6dd79a1
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon Oct 15 11:56:15 2018 +0200

    HUE-8621 [editor] Add dark mode keyboard shortcut to the editor help

:100644 100644 c064754eca 9fc02825c7 M	desktop/core/src/desktop/templates/common_notebook_ko_components.mako

Testing Done

Manual on Chrome

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
tocomplete --> autotocomplete ? 'Show the settings menu where' --> Where ...	Romain Rigaux	Oct. 16, 2018, 12:06 p.m.

Ship it!

desktop/core/src/desktop/templates/common_notebook_ko_components.mako (Diff revision 1)

Show all issues

tocomplete --> autotocomplete ?
'Show the settings menu where' --> Where ...

Johan Åhlén Oct. 16, 2018, 12:06 p.m.

"tocomplete" because of browser cutting it on reviewboard?

Romain Rigaux Oct. 16, 2018, 2:50 p.m.

Indeed, and other nit was about avoiding the 'settings' repetition and having a bit less text

You have a pending review.

Review Board 3.0.3

HUE-8621 [editor] Add dark mode keyboard shortcut to the editor help

Status: Closed (submitted)