HUE-8638 [importer] Add autocomplete of source fields to the editor in the importer

Review Request #13461 - Created Oct. 18, 2018 and submitted

Johan Åhlén
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 2903c19f4670d0948ae24b8399b01c76573c92a3
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 18 14:25:47 2018 +0200

    HUE-8638 [importer] Add autocomplete of source fields to the editor in the importer

:100644 100644 76ed3ce6da 69055bb1e7 M	desktop/core/src/desktop/static/desktop/js/sqlAutocompleter3.js
:100644 100644 9cd6625e10 1b00bfc704 M	desktop/core/src/desktop/static/desktop/spec/sqlAutocompleter3Spec.js
:100644 100644 afb072b8ef b2c0b8056e M	desktop/core/src/desktop/templates/ko_components/ko_simple_ace_editor.mako
:100644 100644 9dafbe695b 8bdbabac7b M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 5350c406d9 0661d19e01 M	desktop/libs/notebook/src/notebook/static/notebook/js/notebook.ko.js

commit 798d34b6d94c1d0f669dccec1c2c9055d3b5a82f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 18 13:41:22 2018 +0200

    HUE-8638 [frontend] Add default set of metadata for temporary entries

:100644 100644 cf907683b7 160106d565 M	desktop/core/src/desktop/static/desktop/js/dataCatalog.js

commit 8d13a73ec4c67129c3f87646f44f0d33d4f3755a
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Oct 18 13:06:55 2018 +0200

    HUE-8638 [frontend] Add the ability to create temporary tables in the data catalog
    
    This will be used to support autocompletion of tables that haven't been created yet.

:100644 100644 42e15d0474 cf907683b7 M	desktop/core/src/desktop/static/desktop/js/dataCatalog.js

Manual on Chrome

https://dl.dropbox.com/s/boame05bwn93ep7/HUE-8638.Autocomplete_in_importer.rev1.mp4?dl=0

also in branch HUE-8638_jahlen

  1. Nice!

    We should probably not mix and max Fields/Editor (will be more complex to generate the correct queries) for now. In the future we could imagine having both toggable and have the content automatically mapped to each format (e.g. SELECT col1 as colA, trim(CAST(col1 as STRING)) as col2 ...), but that's non trivial and can be skipped for v1.

    What would help a lot:
    - name of the table based on the name of the file (in case of file import) or topic name (in case of topic import)
    - listing all the columns in a
    SELECT
    col1,
    col2,.....
    FROM file1
    - Impala or Hive syntax depending on the sourceType
    - SparkSQL when coming from a topic
    - Sample popup compatible (to get data field preview) somehow
    - Live preview when coming from a topic (and we can add custom SQL there too just after)
    - Next next next multi inputs (just to keep in mind)

  2. 
      
Review request changed

Status: Closed (submitted)

Loading...