[core] HUE-8640 fix TestNotebookApi tests

Review Request #13467 - Created Oct. 19, 2018 and submitted

weixia xu
hue
master
HUE-8640
c40b651...
hue
jgauthier, romain

HUE-8640 fix TestNotebookApi tests

/build/env/bin/hue test specific notebook.tests:TestNotebookApi PASSed

  • 0
  • 0
  • 7
  • 0
  • 7
Description From Last Updated
  1. Nice!

    A few questions!

  2. Why not statement_raw anymore?

    1. It throws KeyError, seems no 'statement_raw' in some case.

  3. Some snippets don't have a variables attribute in the tests?

    1. Yes, keyError and sometimes the len is 0.

  4. Do we need to add a "variables": []
    
    here?
    
    cf. last comment
    1. Is the variables for the real query variables? If yes, we can add a separate test for that.

  5. Here the goal is to test the the doc.search field is automatically generated. What was the failure?

    1. doc.search returns None consistently hence always fails.

  6. 
      
  1. 
      
  2. Could we remove some extra 'variables' entities and values here?

  3. Do we really need '"sampleUser":[]'?
  4. 
      
  1. 
      
  2. Got it, thanks!

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/cloudera/hue/commit/3b2be2c729795270e66f479d800a5329808365e0

Loading...